From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: DT support in i2c
Date: Mon, 09 Apr 2012 08:34:46 -0500 [thread overview]
Message-ID: <4F82E576.5090100@gmail.com> (raw)
In-Reply-To: <CAKON4OwPYHP1Zhbc20CtgAvD_qNzAyXC5ndZbMhJh5aSd-W-VA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 04/09/2012 12:26 AM, jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> On Sun, Apr 8, 2012 at 9:17 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On 04/07/2012 06:26 PM, jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>>> Grant, moving of_i2c.c into drivers/i2c would parallel your spi/gpio patches.
>>>
>>> of_i2c_register_devices() needs to be moved up into i2c-core. Right
>>> now the ten bus drivers are individually calling it.
>>
>> I posted patches to do just this a while back and the i2c maintainers
>> didn't like the idea. Feel free to try again. :)
>
> Try resubmitting the patch, but only submit this change. Looking back
> at the original submission Jean was concerned about other aspects of
> your series and it looks like he ignored this part.
Really? Seems pretty clear to me:
> But anyway, I don't buy the whole thing. We currently have a nice
> separation between OF and the underlying bus types. Breaking it all
> just for the sake of saving one call in 4 drivers (out of ~70 in the
> current kernel tree) doesn't seem worth it, at all. It would make
> things harder to maintain, too (I definitely do not want to maintain
> OF-specific code).
Maybe when i2c is the only thing left and there are dozens of OF enabled
i2c drivers he'll feel differently. In the meantime, I've got more
pressing things to spend time on.
Rob
prev parent reply other threads:[~2012-04-09 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-07 23:26 DT support in i2c jonsmirl-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <CAKON4OwBxfstLGFxqR+R9BD6bwD28OD-fCOwLSSs7v_Q=1LOyQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-09 1:17 ` Rob Herring
[not found] ` <4F8238A3.3010502-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-04-09 5:26 ` jonsmirl-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <CAKON4OwPYHP1Zhbc20CtgAvD_qNzAyXC5ndZbMhJh5aSd-W-VA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-09 13:34 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F82E576.5090100@gmail.com \
--to=robherring2-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).