devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Jean-Christophe PLAGNIOL-VILLARD
	<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH] dtc: Basic integer expressions
Date: Mon, 09 Apr 2012 21:48:33 -0600	[thread overview]
Message-ID: <4F83AD91.1060507@wwwdotorg.org> (raw)
In-Reply-To: <20120410023807.GF29577-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>

On 04/09/2012 08:38 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 20:56 Tue 03 Apr     , Stephen Warren wrote:
>> Written by David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>. Additions by me:
>> * Ported to ToT dtc.
>> * Renamed cell to integer throughout.
>> * Implemented value range checks.
>> * Allow U/L/UL/LL/ULL suffix on literals.
>> * Enabled the commented test.
>>
>> Signed-off-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
>> ---
>> v3:
>> * Fix printf warning by s/%ld/%zd/
>> * Support plain "U" as an integer literal suffix
>> * Fix misplaced semi-colons in grammar
>> * Support integer expressions for /memreserve/ and /incbin/ too
>> * Modify eval_literal to check U/L suffixes after strtoull call,
>>   using strspn/strlen
>> * Remove mention of libfdt from comment in tests/integer-expressions.c
>> * Add comment to explain integer_prim range check
>> v2:
>> * s/cell/integer/ throughout.
>> * Allow signed-extended values to pass the overall cell range check.
>> * Allow L/UL/LL/ULL suffix on literals. This is purely for compatibility
>>   with C, and has no effect on dtc's processing.
>> * Enabled the 3 disabled tests.
>
> Stephen what is the status of the define value?

You mean /define/ VAR VALUE? It's on hold right now; I've been waiting
for this patch to be merged before trying to push that, since one of the
objections against the /define/ patch was that we didn't know what the
future dtc expressions syntax would look like, and hence couldn't tell
whether /define/ fit into it. Now at least we know what integer
expressions look like, so can perhaps start thinking about /define/
syntax again...

      parent reply	other threads:[~2012-04-10  3:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-04  2:56 [PATCH] dtc: Basic integer expressions Stephen Warren
     [not found] ` <1333508160-7015-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-09 13:43   ` Jon Loeliger
     [not found]     ` <E1SHEsg-0001Z3-6r-CYoMK+44s/E@public.gmane.org>
2012-04-10  2:29       ` Jean-Christophe PLAGNIOL-VILLARD
     [not found]         ` <20120410022922.GE29577-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-04-10  3:55           ` Stephen Warren
     [not found]             ` <4F83AF3D.6040903-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-10 14:43               ` Jon Loeliger
     [not found]                 ` <E1SHcIC-0007yo-QY-CYoMK+44s/E@public.gmane.org>
2012-04-18  2:52                   ` Stephen Warren
2012-04-10  2:38   ` Jean-Christophe PLAGNIOL-VILLARD
     [not found]     ` <20120410023807.GF29577-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-04-10  3:48       ` Stephen Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F83AD91.1060507@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).