From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [RFC] dt: export of_have_populated_dt Date: Tue, 10 Apr 2012 19:36:15 +0200 Message-ID: <4F846F8F.6090307@linutronix.de> References: <1334070672-11252-1-git-send-email-balajitk@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1334070672-11252-1-git-send-email-balajitk-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Balaji T K Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On 04/10/2012 05:11 PM, Balaji T K wrote: > If of_have_populated_dt is called from module, build fails with "allnodes" > undefined error, so remove inline and export of_have_populated_dt. Why do you need this function at all? You should not need it. *I* introduced it because I need it early x86 setup code to figure out if there a DT available or not. A driver should not care about it. You do have your dev.of_node and this is it. Sebastian