[RFC] dt: export of_have_populated_dt

[RFC] dt: export of_have_populated_dt

[Balaji T K]

If of_have_populated_dt is called from module, build fails with "allnodes"
undefined error, so remove inline and export of_have_populated_dt.

Signed-off-by: Balaji T K <balajitk@ti.com>
---
 drivers/of/base.c  |    6 ++++++
 include/linux/of.h |    6 +-----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 5806449..dc1af42 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -186,6 +186,12 @@ struct property *of_find_property(const struct device_node *np,
 }
 EXPORT_SYMBOL(of_find_property);
 
+bool of_have_populated_dt(void)
+{
+	return allnodes != NULL;
+}
+EXPORT_SYMBOL(of_have_populated_dt);
+
 /**
  * of_find_all_nodes - Get next node in global list
  * @prev:	Previous node or NULL to start iteration
diff --git a/include/linux/of.h b/include/linux/of.h
index fa7fb1d..28e933e 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -92,11 +92,6 @@ extern struct device_node *of_chosen;
 extern struct device_node *of_aliases;
 extern rwlock_t devtree_lock;
 
-static inline bool of_have_populated_dt(void)
-{
-	return allnodes != NULL;
-}
-
 static inline bool of_node_is_root(const struct device_node *node)
 {
 	return node && (node->parent == NULL);
@@ -112,6 +107,7 @@ static inline void of_node_set_flag(struct device_node *n, unsigned long flag)
 	set_bit(flag, &n->_flags);
 }
 
+extern bool of_have_populated_dt(void);
 extern struct device_node *of_find_all_nodes(struct device_node *prev);
 
 /*
-- 
1.7.0.4

Re: [RFC] dt: export of_have_populated_dt

[Cousson, Benoit]

Hi Balaji,

On 4/10/2012 5:11 PM, Balaji T K wrote:
> If of_have_populated_dt is called from module, build fails with "allnodes"
> undefined error, so remove inline and export of_have_populated_dt.

Is this function really called from the MMC driver?

Regards,
Benoit

>
> Signed-off-by: Balaji T K<balajitk@ti.com>
> ---
>   drivers/of/base.c  |    6 ++++++
>   include/linux/of.h |    6 +-----
>   2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 5806449..dc1af42 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -186,6 +186,12 @@ struct property *of_find_property(const struct device_node *np,
>   }
>   EXPORT_SYMBOL(of_find_property);
>
> +bool of_have_populated_dt(void)
> +{
> +	return allnodes != NULL;
> +}
> +EXPORT_SYMBOL(of_have_populated_dt);
> +
>   /**
>    * of_find_all_nodes - Get next node in global list
>    * @prev:	Previous node or NULL to start iteration
> diff --git a/include/linux/of.h b/include/linux/of.h
> index fa7fb1d..28e933e 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -92,11 +92,6 @@ extern struct device_node *of_chosen;
>   extern struct device_node *of_aliases;
>   extern rwlock_t devtree_lock;
>
> -static inline bool of_have_populated_dt(void)
> -{
> -	return allnodes != NULL;
> -}
> -
>   static inline bool of_node_is_root(const struct device_node *node)
>   {
>   	return node&&  (node->parent == NULL);
> @@ -112,6 +107,7 @@ static inline void of_node_set_flag(struct device_node *n, unsigned long flag)
>   	set_bit(flag,&n->_flags);
>   }
>
> +extern bool of_have_populated_dt(void);
>   extern struct device_node *of_find_all_nodes(struct device_node *prev);
>
>   /*

Re: [RFC] dt: export of_have_populated_dt

[Chris Ball]

Hi,

On Tue, Apr 10 2012, Cousson, Benoit wrote:
> Hi Balaji,
>
> On 4/10/2012 5:11 PM, Balaji T K wrote:
>> If of_have_populated_dt is called from module, build fails with "allnodes"
>> undefined error, so remove inline and export of_have_populated_dt.
>
> Is this function really called from the MMC driver?

~/git/linux % git grep of_have_populated_dt drivers/
drivers/gpio/gpio-samsung.c:    if (!of_have_populated_dt())
drivers/mmc/host/omap_hsmmc.c:  if (of_have_populated_dt() && !vdd)
drivers/mmc/host/omap_hsmmc.c:                   (!of_have_populated_dt())) {

- Chris.
-- 
Chris Ball   <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>   <http://printf.net/>
One Laptop Per Child

Re: [RFC] dt: export of_have_populated_dt

[Cousson, Benoit]

Hi Chris,

On 4/10/2012 6:21 PM, Chris Ball wrote:
> Hi,
>
> On Tue, Apr 10 2012, Cousson, Benoit wrote:
>> Hi Balaji,
>>
>> On 4/10/2012 5:11 PM, Balaji T K wrote:
>>> If of_have_populated_dt is called from module, build fails with "allnodes"
>>> undefined error, so remove inline and export of_have_populated_dt.
>>
>> Is this function really called from the MMC driver?
>
> ~/git/linux % git grep of_have_populated_dt drivers/
> drivers/gpio/gpio-samsung.c:    if (!of_have_populated_dt())
> drivers/mmc/host/omap_hsmmc.c:  if (of_have_populated_dt()&&  !vdd)
> drivers/mmc/host/omap_hsmmc.c:                   (!of_have_populated_dt())) {

Gosh, twice... I should be in a wrong branch :-(

Then the next question to Rob...

Rob,
Does it make sense to use that in the driver? So far I was using that 
only in the arch code to make the difference between the DT boot and the 
non-DT boot.

I guess that a driver should rely on of_match_device or non-NULL 
device_node to figure out that?

Thanks,
Benoit

Re: [RFC] dt: export of_have_populated_dt

[Rob Herring]

On 04/10/2012 11:29 AM, Cousson, Benoit wrote:
> Hi Chris,
> 
> On 4/10/2012 6:21 PM, Chris Ball wrote:
>> Hi,
>>
>> On Tue, Apr 10 2012, Cousson, Benoit wrote:
>>> Hi Balaji,
>>>
>>> On 4/10/2012 5:11 PM, Balaji T K wrote:
>>>> If of_have_populated_dt is called from module, build fails with
>>>> "allnodes"
>>>> undefined error, so remove inline and export of_have_populated_dt.
>>>
>>> Is this function really called from the MMC driver?
>>
>> ~/git/linux % git grep of_have_populated_dt drivers/
>> drivers/gpio/gpio-samsung.c:    if (!of_have_populated_dt())
>> drivers/mmc/host/omap_hsmmc.c:  if (of_have_populated_dt()&&  !vdd)
>> drivers/mmc/host/omap_hsmmc.c:                  
>> (!of_have_populated_dt())) {
> 
> Gosh, twice... I should be in a wrong branch :-(
> 
> Then the next question to Rob...
> 
> Rob,
> Does it make sense to use that in the driver? So far I was using that
> only in the arch code to make the difference between the DT boot and the
> non-DT boot.
> 
> I guess that a driver should rely on of_match_device or non-NULL
> device_node to figure out that?
> 

Agreed. of_match_device or device_node ptr check is the right approach.

Rob

> Thanks,
> Benoit

Re: [RFC] dt: export of_have_populated_dt

[Grant Likely]

On Tue, 10 Apr 2012 12:20:27 -0500, Rob Herring <robherring2@gmail.com> wrote:
> On 04/10/2012 11:29 AM, Cousson, Benoit wrote:
> > Hi Chris,
> > 
> > On 4/10/2012 6:21 PM, Chris Ball wrote:
> >> Hi,
> >>
> >> On Tue, Apr 10 2012, Cousson, Benoit wrote:
> >>> Hi Balaji,
> >>>
> >>> On 4/10/2012 5:11 PM, Balaji T K wrote:
> >>>> If of_have_populated_dt is called from module, build fails with
> >>>> "allnodes"
> >>>> undefined error, so remove inline and export of_have_populated_dt.
> >>>
> >>> Is this function really called from the MMC driver?
> >>
> >> ~/git/linux % git grep of_have_populated_dt drivers/
> >> drivers/gpio/gpio-samsung.c:    if (!of_have_populated_dt())
> >> drivers/mmc/host/omap_hsmmc.c:  if (of_have_populated_dt()&&  !vdd)
> >> drivers/mmc/host/omap_hsmmc.c:                  
> >> (!of_have_populated_dt())) {
> > 
> > Gosh, twice... I should be in a wrong branch :-(
> > 
> > Then the next question to Rob...
> > 
> > Rob,
> > Does it make sense to use that in the driver? So far I was using that
> > only in the arch code to make the difference between the DT boot and the
> > non-DT boot.
> > 
> > I guess that a driver should rely on of_match_device or non-NULL
> > device_node to figure out that?
> > 
> 
> Agreed. of_match_device or device_node ptr check is the right approach.

Good; I can safely ignore this patch.  :-)

g.

Re: [RFC] dt: export of_have_populated_dt

[Rajendra Nayak]

On Tuesday 10 April 2012 10:50 PM, Rob Herring wrote:
>> Rob,
>> >  Does it make sense to use that in the driver? So far I was using that
>> >  only in the arch code to make the difference between the DT boot and the
>> >  non-DT boot.
>> >
>> >  I guess that a driver should rely on of_match_device or non-NULL
>> >  device_node to figure out that?
>> >
> Agreed. of_match_device or device_node ptr check is the right approach.

Thanks Rob, I'll post a patch to fix that up.

Re: [RFC] dt: export of_have_populated_dt

[Sebastian Andrzej Siewior]

On 04/10/2012 05:11 PM, Balaji T K wrote:
> If of_have_populated_dt is called from module, build fails with "allnodes"
> undefined error, so remove inline and export of_have_populated_dt.

Why do you need this function at all? You should not need it. *I*
introduced it because I need it early x86 setup code to figure out if
there a DT available or not. A driver should not care about it. You do 
have your dev.of_node and this is it.

Sebastian

Re: [RFC] dt: export of_have_populated_dt

[Rajendra Nayak]

On Tuesday 10 April 2012 08:41 PM, Balaji T K wrote:
> If of_have_populated_dt is called from module, build fails with "allnodes"
> undefined error, so remove inline and export of_have_populated_dt.

Thanks Balaji, for taking care of this while I was out.
But like Rob and Sebastian mentioned, looks like the usage of
of_have_populated_dt() itself is wrong in the first place.
So I will fix that up with a patch shortly.

>
> Signed-off-by: Balaji T K<balajitk@ti.com>
> ---
>   drivers/of/base.c  |    6 ++++++
>   include/linux/of.h |    6 +-----
>   2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 5806449..dc1af42 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -186,6 +186,12 @@ struct property *of_find_property(const struct device_node *np,
>   }
>   EXPORT_SYMBOL(of_find_property);
>
> +bool of_have_populated_dt(void)
> +{
> +	return allnodes != NULL;
> +}
> +EXPORT_SYMBOL(of_have_populated_dt);
> +
>   /**
>    * of_find_all_nodes - Get next node in global list
>    * @prev:	Previous node or NULL to start iteration
> diff --git a/include/linux/of.h b/include/linux/of.h
> index fa7fb1d..28e933e 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -92,11 +92,6 @@ extern struct device_node *of_chosen;
>   extern struct device_node *of_aliases;
>   extern rwlock_t devtree_lock;
>
> -static inline bool of_have_populated_dt(void)
> -{
> -	return allnodes != NULL;
> -}
> -
>   static inline bool of_node_is_root(const struct device_node *node)
>   {
>   	return node&&  (node->parent == NULL);
> @@ -112,6 +107,7 @@ static inline void of_node_set_flag(struct device_node *n, unsigned long flag)
>   	set_bit(flag,&n->_flags);
>   }
>
> +extern bool of_have_populated_dt(void);
>   extern struct device_node *of_find_all_nodes(struct device_node *prev);
>
>   /*