From: David Daney <ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: David Gibson
<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>,
Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Devicetree Discuss
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH v2] dtc: Remove spurious output on stderr
Date: Wed, 11 Apr 2012 18:19:59 -0700 [thread overview]
Message-ID: <4F862DBF.7030502@gmail.com> (raw)
In-Reply-To: <20120411233459.GC8024-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
On 04/11/2012 04:34 PM, David Gibson wrote:
> On Wed, Apr 11, 2012 at 04:32:26PM -0700, Simon Glass wrote:
>> Outputing to stderr is best avoided unless there is an error or warning to
>> display. At present dtc always displays the name of the file it is compiling
>> and the input/output formats. For example:
>>
>> DTC: dts->dts on file "-"
>>
>> This can cause problems in some build systems. For example, U-Boot shows
>> build errors for any boards which use dtc at present. It is typically the
>> only message output during such a build. The C compiler does not output
>> anything in general. The current dtc behaviour makes it difficult to
>> provide a silent build in the normal case where nothing went wrong.
>>
>> Remove the message entirely.
>>
>> Signed-off-by: Simon Glass<sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
> Acked-by: David Gibson<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
>
I agree, I just saw two of them not 30 seconds ago. So FWIW:
Acked-by: Signed-off-by: David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
next prev parent reply other threads:[~2012-04-12 1:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 18:55 [PATCH] dtc: Remove spurious output on stderr Simon Glass
[not found] ` <1334170516-23473-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-04-11 22:45 ` David Gibson
[not found] ` <20120411224557.GA8024-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-04-11 23:17 ` Simon Glass
2012-04-11 23:32 ` [PATCH v2] " Simon Glass
[not found] ` <1334187146-8384-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-04-11 23:34 ` David Gibson
[not found] ` <20120411233459.GC8024-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-04-12 1:19 ` David Daney [this message]
2012-04-14 14:04 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F862DBF.7030502@gmail.com \
--to=ddaney.cavm-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).