Re: [PATCH V3 1/2] staging: iio: add channel info for sampling frequency

[Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>]

On 4/12/2012 2:09 PM, Laxman Dewangan wrote:
> On Thursday 12 April 2012 06:45 PM, Jonathan Cameron wrote:
>> On 4/12/2012 1:38 PM, Laxman Dewangan wrote:
>>> Adding channel info IIO_CHAN_INFO_SAMP_FREQ to select
>>> different sampling frequency per channel wise.
>>>
>>> Signed-off-by: Laxman Dewangan<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>> ---
>>> As per discussion on previous patch, adding channel info
>>> for selecting sampling freqeuncy.
>> To match with the existing devices can we not use the abrieviation
>> for the attribute naming.
>>
>
> Sorry..I did not get it completely.
> Is it like we should have IIO_CHAN_INFO_SAMPLING_FREQUENCY in place 
> of  IIO_CHAN_INFO_SAMP_FREQ?
SAMP_FREQ is fine internally.
>
>
>>> @@ -90,6 +90,7 @@ static const char * const iio_chan_info_postfix[] = {
>>>        [IIO_CHAN_INFO_AVERAGE_RAW] = "mean_raw",
>>>        [IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY]
>>>        = "filter_low_pass_3db_frequency",
>>> +    [IIO_CHAN_INFO_SAMP_FREQ] = "samp_freq",
>> "sampling_frequency"
>
> and then change here as "sampling_frequency"?
>
Yup, that's the one that is (in the general all channels case) already 
in the abi docs...
>
>
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html