From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>
Cc: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org,
viresh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V3 4/4] SPEAr3xx: Add pinctrl support for boards
Date: Fri, 13 Apr 2012 10:18:45 -0600 [thread overview]
Message-ID: <4F8851E5.7050509@wwwdotorg.org> (raw)
In-Reply-To: <81b04bd4fe751633802e539d724facce80e600a4.1334207964.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
On 04/11/2012 11:24 PM, Viresh Kumar wrote:
> Signed-off-by: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>
Just a couple of minor comments below.
> diff --git a/arch/arm/boot/dts/spear300-evb.dts b/arch/arm/boot/dts/spear300-evb.dts
> + pinmux@99000000 {
> + st,pinmux-mode=<2>;
spaces around = here for consistency?
> + state_default: pinmux {
> + i2c0 {
> + st,pins = "i2c0_grp";
> + st,function = "i2c0";
> + };
Do the group names need the "_grp" suffix? If that's what's in your TRM,
it's fine by me, but I'd guess that isn't the case, and if so I'd say
either drop the _grp suffix here, or enhance the binding documentation
to mention the need to add this suffix when writing the .dts file.
next prev parent reply other threads:[~2012-04-13 16:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 5:24 [PATCH V3 0/4] pinctrl: Add SPEAr pinctrl support Viresh Kumar
[not found] ` <cover.1334207964.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2012-04-12 5:24 ` [PATCH V3 1/4] SPEAr: Remove existing padmux support for SPEAr Viresh Kumar
[not found] ` <e45ccf333041c3aa12b7dd821545d5e436c9d1ec.1334207964.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2012-04-13 13:00 ` Linus Walleij
2012-04-12 5:24 ` [PATCH V3 2/4] pinctrl: Add SPEAr pinctrl drivers Viresh Kumar
[not found] ` <3d7a76d17b4366e08b45d528a245147095bbcb10.1334207964.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2012-04-13 13:01 ` Linus Walleij
2012-04-13 16:08 ` Stephen Warren
2012-04-16 3:35 ` Viresh Kumar
2012-04-12 5:24 ` [PATCH V3 4/4] SPEAr3xx: Add pinctrl support for boards Viresh Kumar
[not found] ` <81b04bd4fe751633802e539d724facce80e600a4.1334207964.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2012-04-13 13:05 ` Linus Walleij
2012-04-13 16:18 ` Stephen Warren [this message]
[not found] ` <4F8851E5.7050509-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-16 3:37 ` Viresh Kumar
[not found] ` <4F8B940B.7030700-qxv4g6HH51o@public.gmane.org>
2012-04-16 18:05 ` Stephen Warren
[not found] ` <4F8C5F68.7070105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-16 18:08 ` viresh kumar
[not found] ` <61fe5fe87fdddfc66d21d82b1039de3782b50201.1334207964.git.viresh.kumar@st.com>
[not found] ` <61fe5fe87fdddfc66d21d82b1039de3782b50201.1334207964.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2012-04-13 13:04 ` [PATCH V3 3/4] pinctrl: Add SPEAr3xx pinctrl drivers Linus Walleij
2012-04-13 16:13 ` Stephen Warren
2012-04-16 3:35 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8851E5.7050509@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org \
--cc=viresh.kumar-qxv4g6HH51o@public.gmane.org \
--cc=viresh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).