From: Scott Wood <scottwood@freescale.com>
To: Simon Glass <sjg@chromium.org>
Cc: Devicetree@theia.denx.de,
Discuss <devicetree-discuss@lists.ozlabs.org>,
Jim Lin <jilin@nvidia.com>,
U-Boot Mailing List <u-boot@lists.denx.de>,
Jerry Van Baren <vanbaren@cideas.com>,
Tom Warren <twarren@nvidia.com>
Subject: Re: [PATCH v3 4/7] tegra: fdt: Add NAND controller binding and definitions
Date: Tue, 17 Apr 2012 15:49:08 -0500 [thread overview]
Message-ID: <4F8DD744.1080702@freescale.com> (raw)
In-Reply-To: <CAPnjgZ2OESUgpMb-L0AdJ3EbOzO2Y1GRykuudKpPu2Yyjsh_NA@mail.gmail.com>
On 04/17/2012 03:36 PM, Simon Glass wrote:
> Hi Scott,
>
> On Tue, Apr 17, 2012 at 1:31 PM, Scott Wood <scottwood@freescale.com> wrote:
>> On 04/17/2012 03:18 PM, Simon Glass wrote:
>>> On Tue, Apr 17, 2012 at 12:06 PM, Scott Wood <scottwood@freescale.com> wrote:
>>>> Doesn't the number of cells depend on the GPIO controller binding?
>>>
>>> Yes, but this is the binding Tegra uses.
>>
>> Still, it doesn't belong in the NAND binding. Maybe a future chip wants
>> to use this NAND binding but a different GPIO binding. If nothing else,
>> people tend to copy-and-paste such descriptions. We've still got people
>> adding bindings for Freescale devices saying interrupts are encoded as a
>> pair of cells, even though the interrupt controller now uses four cells
>> per interrupt.
>
> OK I see - are you are saying that we should just say something like:
>
> "nvidia,wp-gpios : GPIO of write-protect line, as defined by gpio bindings"
Yes. If there were more than one GPIO line, you'd specify which one is
which, similar to reg and interrupts.
-Scott
next prev parent reply other threads:[~2012-04-17 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1334688614-4977-1-git-send-email-sjg@chromium.org>
2012-04-17 18:50 ` [PATCH v3 2/7] fdt: Add debugging to fdtdec_get_int/addr() Simon Glass
2012-04-17 18:50 ` [PATCH v3 4/7] tegra: fdt: Add NAND controller binding and definitions Simon Glass
2012-04-17 19:06 ` Scott Wood
2012-04-17 20:18 ` Simon Glass
2012-04-17 20:31 ` Scott Wood
2012-04-17 20:36 ` Simon Glass
2012-04-17 20:49 ` Scott Wood [this message]
[not found] ` <1334688614-4977-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-04-17 18:50 ` [PATCH v3 5/7] tegra: fdt: Add NAND definitions to fdt Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8DD744.1080702@freescale.com \
--to=scottwood@freescale.com \
--cc=Devicetree@theia.denx.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jilin@nvidia.com \
--cc=sjg@chromium.org \
--cc=twarren@nvidia.com \
--cc=u-boot@lists.denx.de \
--cc=vanbaren@cideas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).