From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH V1] dmaengine: tegra: add dma driver Date: Fri, 20 Apr 2012 19:15:14 +0530 Message-ID: <4F91686A.1030000@nvidia.com> References: <1334912896-4614-1-git-send-email-ldewangan@nvidia.com> <1334920487.31825.98.camel@vkoul-udesk3> <4F9153AF.7020901@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F9153AF.7020901-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vinod Koul Cc: "dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Stephen Warren , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi Vinod, On Friday 20 April 2012 05:46 PM, Laxman Dewangan wrote: > Thanks Vinod for quick review. > >>> + * @dma_dev: required DMA master client device. >>> + * @dm_req_id: Peripheral dma requestor ID. >>> + */ >>> +struct tegra_dma_slave { >>> + struct device *client_dev; >>> + enum tegra_dma_requestor dma_req_id; >>> + enum tegra_dma_burst_size burst_size; >> pls remove > if above is OK then I can remove this. > If I add one more member as slave_id for slave requester in struct dma_slave_config then I will not need the tegra_dma header at all and I can get rid of this file. Let me know if this is OK so that I can take care of this in my next patch. Thanks, Laxman