From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH V2] pinctrl: fix signed vs unsigned conditionals inside pinmux_map_to_setting Date: Mon, 23 Apr 2012 11:23:53 -0600 Message-ID: <4F959029.2040409@wwwdotorg.org> References: <1335200518-3640-1-git-send-email-blogic@openwrt.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1335200518-3640-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: John Crispin Cc: Dong Aisheng , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On 04/23/2012 11:01 AM, John Crispin wrote: > pinmux_map_to_setting() uses setting->data.mux.func/group to store the return > code of pinmux_func_name_to_selector/pinctrl_get_group_selector(). However, > struct pinctrl_setting_mux defines these elements as unsigned, resulting in all > error codes getting lost. The conditionals following the assignments will always > evaluate to false thus breaking the error paths. > > This bug can be triggered by loading a pinmux group map from the devicetree > with an invalid function/group string. > > Signed-off-by: John Crispin > Cc: Stephen Warren > Cc: Dong Aisheng Acked-by: Stephen Warren