From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Crispin Subject: Re: [RFC] pinctrl: enhance reporting of errors when loading from DT Date: Wed, 25 Apr 2012 13:16:21 +0200 Message-ID: <4F97DD05.90207@openwrt.org> References: <1335286387-18520-1-git-send-email-blogic@openwrt.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Linus Walleij Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Dong Aisheng List-Id: devicetree@vger.kernel.org Hi Linus >> There are a few places tagged with //FIXME. > No C99 comments. See Documentation/CodingStyle. the //FIXME bits are as described below the tear line only there to show which places I checked. they obviously will be removed in the final patch > So if you're gonna keep them, > /* use plain C comments */ > > And follow up on Stephens comments... i will follow up on stephens comments asap ... John