From: Stephen Warren <swarren@wwwdotorg.org>
To: "Poddar, Sourav" <sourav.poddar@ti.com>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Benoit Cousson <b-cousson@ti.com>,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
Felipe Balbi <balbi@ti.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCHv4 1/2] drivers: input: keypad: Add device tree support
Date: Thu, 26 Apr 2012 08:39:36 -0600 [thread overview]
Message-ID: <4F995E28.1050203@wwwdotorg.org> (raw)
In-Reply-To: <CAKdam56ONhS_drgfHCeY6aKWp3nT0PtDEO5SMCKxG+dGVPS66A@mail.gmail.com>
On 04/26/2012 12:33 AM, Poddar, Sourav wrote:
> On Wed, Apr 25, 2012 at 9:18 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
...
>> It's probably worth considering whether num-rows/columns should be part
>> of matrix-keyboard.txt, and whether linux,keypad-no-autorepeat should be
>> part of some core keyboard binding. Some of the properties in
>> tegra-kbc.txt might be worth generalizing too (debounce/repeat delay,
>> ghost filter)?
>
> Yes, I also think that its a good idea to make some of the above
> binding more generic. Though, I think "linux,keypad-no-autorepeat"
> will still be a custom binding, since its totally on the platform
> whether to use
> autorepeat feature or not?
I think the concept of whether autorepeat should be enabled is pretty
generic. The actual value of the property might well be
board/platform-specific, so may differ in individual board .dts files.
prev parent reply other threads:[~2012-04-26 14:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 9:26 [PATCHv4 1/2] drivers: input: keypad: Add device tree support Sourav Poddar
2012-04-25 9:26 ` [PATCHv4 2/2] arm/dts: omap4-sdp: Add keypad data Sourav Poddar
[not found] ` <1335346004-18108-1-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2012-04-25 10:52 ` [PATCHv4 1/2] drivers: input: keypad: Add device tree support Russell King - ARM Linux
2012-04-25 11:38 ` Roland Stigge
2012-04-25 11:56 ` Poddar, Sourav
2012-04-25 12:15 ` Roland Stigge
2012-04-25 13:00 ` Poddar, Sourav
2012-04-25 15:48 ` Stephen Warren
2012-04-26 6:33 ` Poddar, Sourav
2012-04-26 14:39 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F995E28.1050203@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=rob.herring@calxeda.com \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).