From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Dong Aisheng <b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: b20223-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org,
s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH v4 1/4] dt: add of_get_child_count helper function
Date: Thu, 26 Apr 2012 10:24:11 -0600 [thread overview]
Message-ID: <4F9976AB.1020502@wwwdotorg.org> (raw)
In-Reply-To: <1335451227-27709-1-git-send-email-b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
On 04/26/2012 08:40 AM, Dong Aisheng wrote:
> From: Dong Aisheng <dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> Currently most code to get child count in kernel are almost same,
> add a helper to implement this function for dt to use.
> diff --git a/include/linux/of.h b/include/linux/of.h
> +static inline int of_get_child_count(const struct device_node *np)
> +{
> + struct device_node *child = NULL;
You don't actually need to initialize child here. It doesn't really
matter here, but in a more complex function, it might hide a
used-before-initialized error.
next prev parent reply other threads:[~2012-04-26 16:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 14:40 [PATCH v4 1/4] dt: add of_get_child_count helper function Dong Aisheng
2012-04-26 14:40 ` [PATCH v3 2/4] pinctrl: pinctrl-imx: add imx pinctrl core driver Dong Aisheng
[not found] ` <1335451227-27709-2-git-send-email-b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-04-26 14:44 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-26 15:15 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120426151536.GO9142-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-04-27 5:48 ` Shawn Guo
[not found] ` <20120427054842.GJ2234-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-04-27 6:28 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-27 7:25 ` Shawn Guo
2012-04-27 7:11 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-27 8:11 ` Shawn Guo
2012-04-27 9:29 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-27 3:48 ` Dong Aisheng
2012-04-27 6:31 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-27 7:30 ` Sascha Hauer
2012-04-26 14:44 ` Dong Aisheng
2012-04-27 5:30 ` Shawn Guo
2012-04-27 8:54 ` Shawn Guo
[not found] ` <20120427085402.GV2234-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-04-27 11:24 ` Dong Aisheng
2012-04-26 14:40 ` [PATCH v3 3/4] pinctrl: pinctrl-imx: add imx6q pinctrl driver Dong Aisheng
2012-04-27 5:35 ` Shawn Guo
2012-04-27 6:45 ` Sascha Hauer
[not found] ` <20120427064519.GO17184-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-27 7:16 ` Dong Aisheng
2012-04-26 14:40 ` [PATCH v3 4/4] mmc: sdhci-imx-esdhc: convert to use pinctrl subsystem Dong Aisheng
2012-04-26 16:32 ` Stephen Warren
2012-04-27 7:35 ` Sascha Hauer
[not found] ` <20120427073504.GS17184-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-27 8:29 ` Dong Aisheng
[not found] ` <20120427082930.GC826-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-04-27 8:26 ` Shawn Guo
2012-04-27 8:31 ` Sascha Hauer
2012-04-27 8:54 ` Dong Aisheng
2012-04-27 8:47 ` Sascha Hauer
2012-04-27 9:13 ` Dong Aisheng
[not found] ` <1335451227-27709-1-git-send-email-b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-04-26 16:24 ` Stephen Warren [this message]
[not found] ` <4F9976AB.1020502-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-27 3:28 ` [PATCH v4 1/4] dt: add of_get_child_count helper function Dong Aisheng
[not found] ` <20120427032831.GE26070-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-04-27 3:36 ` [PATCH v5 1/1] " Dong Aisheng
2012-04-27 15:25 ` Stephen Warren
2012-05-01 23:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9976AB.1020502@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=b20223-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).