devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding
	<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>,
	Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>,
	Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v2] ARM: dt: tegra20: Add GART device
Date: Thu, 03 May 2012 12:58:39 -0600	[thread overview]
Message-ID: <4FA2D55F.2090708@wwwdotorg.org> (raw)
In-Reply-To: <4FA2CE32.7010406-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>

On 05/03/2012 12:28 PM, Stephen Warren wrote:
> On 04/16/2012 09:04 AM, Thierry Reding wrote:
>> This commit adds the device node required to probe NVIDIA Tegra 20 GART
>> hardware from the device tree.
> 
>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> 
>> +	gart: gart@7000f000 {
>> +		compatible = "nvidia,tegra20-gart";
>> +		reg = < 0x7000f000 0x00000100    /* controller registers */
>> +		        0x58000000 0x02000000 >; /* GART aperture */
>> +	};
...
> As such, I think this node should be more like:
> 
> mc: mc@7000f000 {
>     compatible = "nvidia,tegra20-mc";
>     reg = <0x7000f000 0x00000100>;
> };
> 
> Then, one of following options can be taken:
[to represent the fact that MC and GART are essentially the same HW module]
...

Yet another option is to explicitly use the MFD subsystem for this; I
guess options 1 and 3 that I gave were essentially open-coding MFD anyway.

Offline, Hiroshi mentioned that he had looked at MFD, and ended up
thinking it was a rather heavy-weight solution in this case though.

  parent reply	other threads:[~2012-05-03 18:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16 15:04 [PATCH v2] ARM: dt: tegra20: Add GART device Thierry Reding
     [not found] ` <1334588670-15124-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2012-04-16 18:47   ` Stephen Warren
2012-05-03 18:28   ` Stephen Warren
     [not found]     ` <4FA2CE32.7010406-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-03 18:58       ` Stephen Warren [this message]
     [not found]         ` <4FA2D55F.2090708-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-04  5:23           ` Hiroshi Doyu
2012-05-04  9:13       ` Hiroshi Doyu
     [not found]         ` <20120504.121357.1085445784831612281.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-04 17:24           ` Stephen Warren
     [not found]             ` <4FA410DD.3090105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-07 11:47               ` Hiroshi Doyu
     [not found]                 ` <20120507.144758.1558303336683449254.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-07 16:06                   ` Stephen Warren
     [not found]                     ` <4FA7F316.7070904-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-08  6:03                       ` Hiroshi Doyu
2012-05-08  6:09                       ` Hiroshi Doyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA2D55F.2090708@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=joerg.roedel-5C7GfCeVMHo@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    --cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).