devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robherring2@gmail.com>
To: Roland Stigge <stigge@antcom.de>
Cc: a.zummo@towertech.it, grant.likely@secretlab.ca,
	rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
	arm@kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH RESEND v5] rtc: Add device tree support for LPC32xx
Date: Thu, 03 May 2012 14:36:43 -0500	[thread overview]
Message-ID: <4FA2DE4B.3070606@gmail.com> (raw)
In-Reply-To: <1336073581-25667-1-git-send-email-stigge@antcom.de>

On 05/03/2012 02:33 PM, Roland Stigge wrote:
> This patch adds device tree support for rtc-lpc32xx.c
> 
> Signed-off-by: Roland Stigge <stigge@antcom.de>
> 

Acked-by: Rob Herring <rob.herring@calxeda.com>

> ---
> 
> Applies to v3.4-rc5
> 
> Changes since v4:
> * Reduced "compatible" strings to just the first one
> 
>  Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt |   15 +++++++++++++++
>  drivers/rtc/rtc-lpc32xx.c                             |   12 +++++++++++-
>  2 files changed, 26 insertions(+), 1 deletion(-)
> 
> --- /dev/null
> +++ linux-2.6/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt
> @@ -0,0 +1,15 @@
> +* NXP LPC32xx SoC Real Time Clock controller
> +
> +Required properties:
> +- compatible: must be "nxp,lpc3220-rtc"
> +- reg: physical base address of the controller and length of memory mapped
> +  region.
> +- interrupts: The RTC interrupt
> +
> +Example:
> +
> +	rtc@40024000 {
> +		compatible = "nxp,lpc3220-rtc";
> +		reg = <0x40024000 0x1000>;
> +		interrupts = <52 0>;
> +	};
> --- linux-2.6.orig/drivers/rtc/rtc-lpc32xx.c
> +++ linux-2.6/drivers/rtc/rtc-lpc32xx.c
> @@ -19,6 +19,7 @@
>  #include <linux/rtc.h>
>  #include <linux/slab.h>
>  #include <linux/io.h>
> +#include <linux/of.h>
>  
>  /*
>   * Clock and Power control register offsets
> @@ -386,13 +387,22 @@ static const struct dev_pm_ops lpc32xx_r
>  #define LPC32XX_RTC_PM_OPS NULL
>  #endif
>  
> +#ifdef CONFIG_OF
> +static const struct of_device_id lpc32xx_rtc_match[] = {
> +	{ .compatible = "nxp,lpc3220-rtc" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, lpc32xx_rtc_match);
> +#endif
> +
>  static struct platform_driver lpc32xx_rtc_driver = {
>  	.probe		= lpc32xx_rtc_probe,
>  	.remove		= __devexit_p(lpc32xx_rtc_remove),
>  	.driver = {
>  		.name	= RTC_NAME,
>  		.owner	= THIS_MODULE,
> -		.pm	= LPC32XX_RTC_PM_OPS
> +		.pm	= LPC32XX_RTC_PM_OPS,
> +		.of_match_table = of_match_ptr(lpc32xx_rtc_match),
>  	},
>  };
>  
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss

  reply	other threads:[~2012-05-03 19:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-03 19:33 [PATCH RESEND v5] rtc: Add device tree support for LPC32xx Roland Stigge
2012-05-03 19:36 ` Rob Herring [this message]
     [not found] ` <1336073581-25667-1-git-send-email-stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>
2012-05-04 12:58   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA2DE4B.3070606@gmail.com \
    --to=robherring2@gmail.com \
    --cc=a.zummo@towertech.it \
    --cc=arm@kernel.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=stigge@antcom.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).