From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Samuel Ortiz <sameo@linux.intel.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Misael Lopez Cruz <misael.lopez@ti.com>,
Liam Girdwood <lrg@ti.com>, "Cousson, Benoit" <b-cousson@ti.com>
Subject: Re: [PATCH] ASoC: twl6040: Support for DT
Date: Mon, 14 May 2012 14:38:20 +0300 [thread overview]
Message-ID: <4FB0EEAC.6060204@ti.com> (raw)
In-Reply-To: <20120511203425.GB29835@opensource.wolfsonmicro.com>
On 05/11/2012 11:34 PM, Mark Brown wrote:
> The issue is the tastefulness. Just looking at the binding it's
> immediately clear that the only thing that the extra levels of
> indirection are adding is the removal of the mfd_add_cells() call from
> the MFD driver which isn't particularly helping anything and is
> basically Linux specific.
It is not really a coincident that we have the drivers structured in a
way they are at the moment (with or without MFD).
We have several functionality provided by this chip (twl6040). In one
chip it provides audio (twl6040-codec), vibra (twl6040-vibra) and we are
going to have few more additions as well (GPO, clock driver to provide
the McPDM functional clock).
We might see more integrated solution in a future which would combine
the current pmic and the audio in a single chip. If this happens we can
just use the dts sections describing the functionalities of the twl6040
appended to this - theoretical - chip.
The child (or drivers for the functionality) only needs small update for
compatible_of, and new chip access wrapper.
In this case the core chip driver (twl6040 MFD) will no longer
exist/make sense since the functionality provided by the twl6040 chip
has been merged together with the PMIC.
You might be right that the resulting dts section for the chip is just
represents the current MD stack, but if I want to prepare for the future
this is the way I think is the best for us.
--
Péter
next prev parent reply other threads:[~2012-05-14 11:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120509133511.GQ3955@opensource.wolfsonmicro.com>
[not found] ` <20120509133511.GQ3955-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-05-11 11:02 ` [PATCH] ASoC: twl6040: Support for DT Cousson, Benoit
2012-05-11 13:08 ` Mark Brown
[not found] ` <20120511130816.GB3960-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-05-11 15:44 ` Cousson, Benoit
2012-05-11 20:34 ` Mark Brown
2012-05-14 11:38 ` Peter Ujfalusi [this message]
2012-05-14 12:11 ` Mark Brown
2012-05-15 8:00 ` Peter Ujfalusi
2012-05-14 15:34 ` Tony Lindgren
2012-05-15 7:41 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB0EEAC.6060204@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=b-cousson@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).