From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Stigge Subject: Re: [PATCH] MTD: LPC32xx MLC NAND driver Date: Tue, 15 May 2012 17:56:32 +0200 Message-ID: <4FB27CB0.8000308@antcom.de> References: <1337091832-10138-1-git-send-email-stigge@antcom.de> <20120515143428.GC13860@n2100.arm.linux.org.uk> <4FB27B24.3030604@antcom.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FB27B24.3030604@antcom.de> Sender: linux-doc-owner@vger.kernel.org To: Russell King - ARM Linux Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, dwmw2@infradead.org, kevin.wells@nxp.com, srinivas.bakki@nxp.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 05/15/2012 05:49 PM, Roland Stigge wrote: >>> + >>> + sg_init_one(&host->sgl, mem, len); >>> + >>> + res = dma_map_sg(host->dma_chan->device->dev, &host->sgl, 1, dir); >> >> Also note that dma transfer directions and dma data directions are >> different things. You shouldn't mix the two. Can I safely use DMA_BIDIRECTIONAL here (practically, it works - just tested), because the caller asks for read _or_ write? Or do I need to formally convert enum dma_transfer_direction to enum dma_data_direction? Thanks in advance, Roland