* [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment
@ 2012-06-10 17:24 Fabio Estevam
2012-06-10 17:24 ` [PATCH 2/4] dt: fsl-mma8450.tx: Add missing 'reg' description Fabio Estevam
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Fabio Estevam @ 2012-06-10 17:24 UTC (permalink / raw)
To: grant.likely
Cc: rob.herring, shawn.guo, rob, kernel, devicetree-discuss,
linux-doc, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Fix gpio number assignment, so that it can match the number stated in the comment.
Cc:
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
.../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
index c7e404b..fea541e 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
@@ -29,6 +29,6 @@ esdhc@70008000 {
compatible = "fsl,imx51-esdhc";
reg = <0x70008000 0x4000>;
interrupts = <2>;
- cd-gpios = <&gpio0 6 0>; /* GPIO1_6 */
- wp-gpios = <&gpio0 5 0>; /* GPIO1_5 */
+ cd-gpios = <&gpio1 6 0>; /* GPIO1_6 */
+ wp-gpios = <&gpio1 5 0>; /* GPIO1_5 */
};
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/4] dt: fsl-mma8450.tx: Add missing 'reg' description 2012-06-10 17:24 [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment Fabio Estevam @ 2012-06-10 17:24 ` Fabio Estevam 2012-06-10 17:24 ` [PATCH 3/4] dt: fsl-fec.txt: Fix gpio number assignment Fabio Estevam ` (2 subsequent siblings) 3 siblings, 0 replies; 10+ messages in thread From: Fabio Estevam @ 2012-06-10 17:24 UTC (permalink / raw) To: grant.likely Cc: rob.herring, shawn.guo, rob, kernel, devicetree-discuss, linux-doc, Fabio Estevam From: Fabio Estevam <fabio.estevam@freescale.com> Add missing 'reg' description. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> ---- .../devicetree/bindings/input/fsl-mma8450.txt | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/input/fsl-mma8450.txt b/Documentation/devicetree/bindings/input/fsl-mma8450.txt index a00c94c..0b96e57 100644 --- a/Documentation/devicetree/bindings/input/fsl-mma8450.txt +++ b/Documentation/devicetree/bindings/input/fsl-mma8450.txt @@ -2,6 +2,7 @@ Required properties: - compatible : "fsl,mma8450". +- reg: the I2C address of MMA8450 Example: -- 1.7.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/4] dt: fsl-fec.txt: Fix gpio number assignment 2012-06-10 17:24 [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment Fabio Estevam 2012-06-10 17:24 ` [PATCH 2/4] dt: fsl-mma8450.tx: Add missing 'reg' description Fabio Estevam @ 2012-06-10 17:24 ` Fabio Estevam 2012-06-10 17:24 ` [PATCH 4/4] dt: mc13xxx.txt: " Fabio Estevam 2012-06-10 23:11 ` [PATCH 1/4] dt: fsl-imx-esdhc.txt: " Rob Herring 3 siblings, 0 replies; 10+ messages in thread From: Fabio Estevam @ 2012-06-10 17:24 UTC (permalink / raw) To: grant.likely Cc: rob.herring, shawn.guo, rob, kernel, devicetree-discuss, linux-doc, Fabio Estevam From: Fabio Estevam <fabio.estevam@freescale.com> Fix gpio number assignment, so that it can match the number stated in the comment. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- Documentation/devicetree/bindings/net/fsl-fec.txt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt index 7ab9e1a..4616fc2 100644 --- a/Documentation/devicetree/bindings/net/fsl-fec.txt +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt @@ -19,6 +19,6 @@ ethernet@83fec000 { reg = <0x83fec000 0x4000>; interrupts = <87>; phy-mode = "mii"; - phy-reset-gpios = <&gpio1 14 0>; /* GPIO2_14 */ + phy-reset-gpios = <&gpio2 14 0>; /* GPIO2_14 */ local-mac-address = [00 04 9F 01 1B B9]; }; -- 1.7.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/4] dt: mc13xxx.txt: Fix gpio number assignment 2012-06-10 17:24 [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment Fabio Estevam 2012-06-10 17:24 ` [PATCH 2/4] dt: fsl-mma8450.tx: Add missing 'reg' description Fabio Estevam 2012-06-10 17:24 ` [PATCH 3/4] dt: fsl-fec.txt: Fix gpio number assignment Fabio Estevam @ 2012-06-10 17:24 ` Fabio Estevam 2012-06-10 23:11 ` [PATCH 1/4] dt: fsl-imx-esdhc.txt: " Rob Herring 3 siblings, 0 replies; 10+ messages in thread From: Fabio Estevam @ 2012-06-10 17:24 UTC (permalink / raw) To: grant.likely Cc: rob.herring, shawn.guo, rob, kernel, devicetree-discuss, linux-doc, Fabio Estevam From: Fabio Estevam <fabio.estevam@freescale.com> Fix gpio number assignment, so that it can match the number stated in the comment. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- Documentation/devicetree/bindings/mfd/mc13xxx.txt | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/mc13xxx.txt b/Documentation/devicetree/bindings/mfd/mc13xxx.txt index 19f6af4..baf0798 100644 --- a/Documentation/devicetree/bindings/mfd/mc13xxx.txt +++ b/Documentation/devicetree/bindings/mfd/mc13xxx.txt @@ -46,8 +46,8 @@ Examples: ecspi@70010000 { /* ECSPI1 */ fsl,spi-num-chipselects = <2>; - cs-gpios = <&gpio3 24 0>, /* GPIO4_24 */ - <&gpio3 25 0>; /* GPIO4_25 */ + cs-gpios = <&gpio4 24 0>, /* GPIO4_24 */ + <&gpio4 25 0>; /* GPIO4_25 */ status = "okay"; pmic: mc13892@0 { -- 1.7.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment 2012-06-10 17:24 [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment Fabio Estevam ` (2 preceding siblings ...) 2012-06-10 17:24 ` [PATCH 4/4] dt: mc13xxx.txt: " Fabio Estevam @ 2012-06-10 23:11 ` Rob Herring 2012-06-11 2:03 ` Fabio Estevam 3 siblings, 1 reply; 10+ messages in thread From: Rob Herring @ 2012-06-10 23:11 UTC (permalink / raw) To: Fabio Estevam Cc: grant.likely, Fabio Estevam, linux-doc, devicetree-discuss, rob.herring, kernel On 06/10/2012 12:24 PM, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Fix gpio number assignment, so that it can match the number stated in the comment. > > Cc: > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > .../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt > index c7e404b..fea541e 100644 > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt > @@ -29,6 +29,6 @@ esdhc@70008000 { > compatible = "fsl,imx51-esdhc"; > reg = <0x70008000 0x4000>; > interrupts = <2>; > - cd-gpios = <&gpio0 6 0>; /* GPIO1_6 */ > - wp-gpios = <&gpio0 5 0>; /* GPIO1_5 */ > + cd-gpios = <&gpio1 6 0>; /* GPIO1_6 */ > + wp-gpios = <&gpio1 5 0>; /* GPIO1_5 */ Are you sure all these aren't just DT is 0 based and the chip is 1 based numbering? Rob > }; ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment 2012-06-10 23:11 ` [PATCH 1/4] dt: fsl-imx-esdhc.txt: " Rob Herring @ 2012-06-11 2:03 ` Fabio Estevam 2012-06-11 4:11 ` Rob Herring 0 siblings, 1 reply; 10+ messages in thread From: Fabio Estevam @ 2012-06-11 2:03 UTC (permalink / raw) To: Rob Herring Cc: grant.likely, Fabio Estevam, linux-doc, devicetree-discuss, rob.herring, kernel On Sun, Jun 10, 2012 at 8:11 PM, Rob Herring <robherring2@gmail.com> wrote: > On 06/10/2012 12:24 PM, Fabio Estevam wrote: >> From: Fabio Estevam <fabio.estevam@freescale.com> >> >> Fix gpio number assignment, so that it can match the number stated in the comment. >> >> Cc: >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> >> --- >> .../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt >> index c7e404b..fea541e 100644 >> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt >> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt >> @@ -29,6 +29,6 @@ esdhc@70008000 { >> compatible = "fsl,imx51-esdhc"; >> reg = <0x70008000 0x4000>; >> interrupts = <2>; >> - cd-gpios = <&gpio0 6 0>; /* GPIO1_6 */ >> - wp-gpios = <&gpio0 5 0>; /* GPIO1_5 */ >> + cd-gpios = <&gpio1 6 0>; /* GPIO1_6 */ >> + wp-gpios = <&gpio1 5 0>; /* GPIO1_5 */ > > Are you sure all these aren't just DT is 0 based and the chip is 1 based > numbering? We start counting gpio number from 0 in i.mx, so the DT number and the GPIO number should match. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment 2012-06-11 2:03 ` Fabio Estevam @ 2012-06-11 4:11 ` Rob Herring 2012-06-11 6:50 ` Sascha Hauer 0 siblings, 1 reply; 10+ messages in thread From: Rob Herring @ 2012-06-11 4:11 UTC (permalink / raw) To: Fabio Estevam Cc: grant.likely, Fabio Estevam, linux-doc, devicetree-discuss, rob.herring, kernel On 06/10/2012 09:03 PM, Fabio Estevam wrote: > On Sun, Jun 10, 2012 at 8:11 PM, Rob Herring <robherring2@gmail.com> wrote: >> On 06/10/2012 12:24 PM, Fabio Estevam wrote: >>> From: Fabio Estevam <fabio.estevam@freescale.com> >>> >>> Fix gpio number assignment, so that it can match the number stated in the comment. >>> >>> Cc: >>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> >>> --- >>> .../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt >>> index c7e404b..fea541e 100644 >>> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt >>> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt >>> @@ -29,6 +29,6 @@ esdhc@70008000 { >>> compatible = "fsl,imx51-esdhc"; >>> reg = <0x70008000 0x4000>; >>> interrupts = <2>; >>> - cd-gpios = <&gpio0 6 0>; /* GPIO1_6 */ >>> - wp-gpios = <&gpio0 5 0>; /* GPIO1_5 */ >>> + cd-gpios = <&gpio1 6 0>; /* GPIO1_6 */ >>> + wp-gpios = <&gpio1 5 0>; /* GPIO1_5 */ >> >> Are you sure all these aren't just DT is 0 based and the chip is 1 based >> numbering? > > We start counting gpio number from 0 in i.mx, so the DT number and the > GPIO number should match. I'm talking about bank numbers, not gpio numbers: /* There's a off-by-one betweem the gpio bank number and the gpiochip */ /* range e.g. GPIO_1_5 is gpio 5 under linux */ #define IMX_GPIO_NR(bank, nr) (((bank) - 1) * 32 + (nr)) Rob ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment 2012-06-11 4:11 ` Rob Herring @ 2012-06-11 6:50 ` Sascha Hauer 2012-06-11 10:22 ` Fabio Estevam 2012-06-11 14:25 ` Rob Herring 0 siblings, 2 replies; 10+ messages in thread From: Sascha Hauer @ 2012-06-11 6:50 UTC (permalink / raw) To: Rob Herring Cc: Fabio Estevam, grant.likely, Fabio Estevam, linux-doc, devicetree-discuss, rob.herring, kernel On Sun, Jun 10, 2012 at 11:11:13PM -0500, Rob Herring wrote: > On 06/10/2012 09:03 PM, Fabio Estevam wrote: > > On Sun, Jun 10, 2012 at 8:11 PM, Rob Herring <robherring2@gmail.com> wrote: > >> On 06/10/2012 12:24 PM, Fabio Estevam wrote: > >>> From: Fabio Estevam <fabio.estevam@freescale.com> > >>> > >>> Fix gpio number assignment, so that it can match the number stated in the comment. > >>> > >>> Cc: > >>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > >>> --- > >>> .../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 4 ++-- > >>> 1 files changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt > >>> index c7e404b..fea541e 100644 > >>> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt > >>> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt > >>> @@ -29,6 +29,6 @@ esdhc@70008000 { > >>> compatible = "fsl,imx51-esdhc"; > >>> reg = <0x70008000 0x4000>; > >>> interrupts = <2>; > >>> - cd-gpios = <&gpio0 6 0>; /* GPIO1_6 */ > >>> - wp-gpios = <&gpio0 5 0>; /* GPIO1_5 */ > >>> + cd-gpios = <&gpio1 6 0>; /* GPIO1_6 */ > >>> + wp-gpios = <&gpio1 5 0>; /* GPIO1_5 */ > >> > >> Are you sure all these aren't just DT is 0 based and the chip is 1 based > >> numbering? > > > > We start counting gpio number from 0 in i.mx, so the DT number and the > > GPIO number should match. > > I'm talking about bank numbers, not gpio numbers: > > /* There's a off-by-one betweem the gpio bank number and the gpiochip */ > /* range e.g. GPIO_1_5 is gpio 5 under linux */ > #define IMX_GPIO_NR(bank, nr) (((bank) - 1) * 32 + (nr)) Traditionally I started counting at 0 no matter what the datasheet told. Now we go to match the numbering with the datasheets, which of course can be confusing while transitioning this. Fabios patch is correct, there is no gpio0 in the devicetree. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment 2012-06-11 6:50 ` Sascha Hauer @ 2012-06-11 10:22 ` Fabio Estevam 2012-06-11 14:25 ` Rob Herring 1 sibling, 0 replies; 10+ messages in thread From: Fabio Estevam @ 2012-06-11 10:22 UTC (permalink / raw) To: Sascha Hauer Cc: Rob Herring, grant.likely, Fabio Estevam, linux-doc, devicetree-discuss, rob.herring, kernel Hi Sascha, On Mon, Jun 11, 2012 at 3:50 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote: > Traditionally I started counting at 0 no matter what the datasheet told. > Now we go to match the numbering with the datasheets, which of course > can be confusing while transitioning this. > Fabios patch is correct, there is no gpio0 in the devicetree. Who could pick this patch series? Thanks, Fabio Estevam ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment 2012-06-11 6:50 ` Sascha Hauer 2012-06-11 10:22 ` Fabio Estevam @ 2012-06-11 14:25 ` Rob Herring 1 sibling, 0 replies; 10+ messages in thread From: Rob Herring @ 2012-06-11 14:25 UTC (permalink / raw) To: Sascha Hauer Cc: Fabio Estevam, grant.likely, Fabio Estevam, linux-doc, devicetree-discuss, kernel On 06/11/2012 01:50 AM, Sascha Hauer wrote: > On Sun, Jun 10, 2012 at 11:11:13PM -0500, Rob Herring wrote: >> On 06/10/2012 09:03 PM, Fabio Estevam wrote: >>> On Sun, Jun 10, 2012 at 8:11 PM, Rob Herring <robherring2@gmail.com> wrote: >>>> On 06/10/2012 12:24 PM, Fabio Estevam wrote: >>>>> From: Fabio Estevam <fabio.estevam@freescale.com> >>>>> >>>>> Fix gpio number assignment, so that it can match the number stated in the comment. >>>>> >>>>> Cc: >>>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> >>>>> --- >>>>> .../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 4 ++-- >>>>> 1 files changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt >>>>> index c7e404b..fea541e 100644 >>>>> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt >>>>> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt >>>>> @@ -29,6 +29,6 @@ esdhc@70008000 { >>>>> compatible = "fsl,imx51-esdhc"; >>>>> reg = <0x70008000 0x4000>; >>>>> interrupts = <2>; >>>>> - cd-gpios = <&gpio0 6 0>; /* GPIO1_6 */ >>>>> - wp-gpios = <&gpio0 5 0>; /* GPIO1_5 */ >>>>> + cd-gpios = <&gpio1 6 0>; /* GPIO1_6 */ >>>>> + wp-gpios = <&gpio1 5 0>; /* GPIO1_5 */ >>>> >>>> Are you sure all these aren't just DT is 0 based and the chip is 1 based >>>> numbering? >>> >>> We start counting gpio number from 0 in i.mx, so the DT number and the >>> GPIO number should match. >> >> I'm talking about bank numbers, not gpio numbers: >> >> /* There's a off-by-one betweem the gpio bank number and the gpiochip */ >> /* range e.g. GPIO_1_5 is gpio 5 under linux */ >> #define IMX_GPIO_NR(bank, nr) (((bank) - 1) * 32 + (nr)) > > Traditionally I started counting at 0 no matter what the datasheet told. > Now we go to match the numbering with the datasheets, which of course > can be confusing while transitioning this. > Fabios patch is correct, there is no gpio0 in the devicetree. > Okay, applied. Rob ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-06-11 14:25 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-06-10 17:24 [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment Fabio Estevam 2012-06-10 17:24 ` [PATCH 2/4] dt: fsl-mma8450.tx: Add missing 'reg' description Fabio Estevam 2012-06-10 17:24 ` [PATCH 3/4] dt: fsl-fec.txt: Fix gpio number assignment Fabio Estevam 2012-06-10 17:24 ` [PATCH 4/4] dt: mc13xxx.txt: " Fabio Estevam 2012-06-10 23:11 ` [PATCH 1/4] dt: fsl-imx-esdhc.txt: " Rob Herring 2012-06-11 2:03 ` Fabio Estevam 2012-06-11 4:11 ` Rob Herring 2012-06-11 6:50 ` Sascha Hauer 2012-06-11 10:22 ` Fabio Estevam 2012-06-11 14:25 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).