[PATCH V2 0/2] arm/dts: Add OMAP2420 SDP support

[PATCH V2 0/2] arm/dts: Add OMAP2420 SDP support

[Jon Hunter]

This series fixes the OMAP2 interrupt controller binding and adds support for
the OMAP2420 SDP board. I have verified that the kernel boots with device-tree
on this board.

This series is based upon the linux-omap master branch (3.5-rc1).

Jon Hunter (2):
  arm/dts: OMAP2: Add support for OMAP2420 SDP
  arm/dts: OMAP2: Fix interrupt controller binding

 arch/arm/boot/dts/omap2.dtsi       |    2 ++
 arch/arm/boot/dts/omap2420-sdp.dts |   20 ++++++++++++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap2420-sdp.dts

-- 
1.7.9.5

[PATCH V2 1/2] arm/dts: OMAP2: Add support for OMAP2420 SDP

[Jon Hunter]

Simple DTS file for OMAP2420 SDP adding memory information to allow device-tree
testing on an OMAP2420 SDP.

Verified that kernel boots with DT using a simple RAMDISK file-system on
OMAP2420 SDP.

Signed-off-by: Jon Hunter <jon-hunter@ti.com>
---
 arch/arm/boot/dts/omap2420-sdp.dts |   20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap2420-sdp.dts

diff --git a/arch/arm/boot/dts/omap2420-sdp.dts b/arch/arm/boot/dts/omap2420-sdp.dts
new file mode 100644
index 0000000..2c292c9
--- /dev/null
+++ b/arch/arm/boot/dts/omap2420-sdp.dts
@@ -0,0 +1,20 @@
+/*
+ * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+
+/include/ "omap2.dtsi"
+
+/ {
+	model = "TI OMAP2420 SDP board";
+	compatible = "ti,omap2-sdp", "ti,omap2420", "ti,omap2";
+
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x84000000>; /* 64 MB */
+	};
+};
-- 
1.7.9.5

[PATCH V2 2/2] arm/dts: OMAP2: Fix interrupt controller binding

[Jon Hunter]

When booting with device-tree on an OMAP2420 SDP, the kernel is hanging when
initialising the interrupts and following kernel dumps is seen ...

[    0.000000] ------------[ cut here ]------------
[    0.000000] WARNING: at arch/arm/mach-omap2/irq.c:271 omap_intc_of_init+0x50/0xb4()
[    0.000000] unable to get intc registers
[    0.000000] Modules linked in:
[    0.000000] [<c001befc>] (unwind_backtrace+0x0/0xf4) from [<c0040c34>] (warn_slowpath_common+0x4c/0x64)
[    0.000000] [<c0040c34>] (warn_slowpath_common+0x4c/0x64) from [<c0040ce0>] (warn_slowpath_fmt+0x30/0x40)
[    0.000000] [<c0040ce0>] (warn_slowpath_fmt+0x30/0x40) from [<c066b8a4>] (omap_intc_of_init+0x50/0xb4)
[    0.000000] [<c066b8a4>] (omap_intc_of_init+0x50/0xb4) from [<c0688b70>] (of_irq_init+0x144/0x288)
[    0.000000] [<c0688b70>] (of_irq_init+0x144/0x288) from [<c0663294>] (init_IRQ+0x14/0x1c)
[    0.000000] [<c0663294>] (init_IRQ+0x14/0x1c) from [<c06607fc>] (start_kernel+0x198/0x304)
[    0.000000] [<c06607fc>] (start_kernel+0x198/0x304) from [<80008044>] (0x80008044)
[    0.000000] ---[ end trace 1b75b31a2719ed1c ]---
[    0.000000] of_irq_init: children remain, but no parents

The OMAP2 interrupt controller binding is missing the number of interrupts and
interrupt controller register address. Adding these fixes the problem.

This is based upon latest linux-omap master (3.5-rc1) git tree.

Signed-off-by: Jon Hunter <jon-hunter@ti.com>
---
 arch/arm/boot/dts/omap2.dtsi |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/omap2.dtsi b/arch/arm/boot/dts/omap2.dtsi
index f2ab4ea..581cb08 100644
--- a/arch/arm/boot/dts/omap2.dtsi
+++ b/arch/arm/boot/dts/omap2.dtsi
@@ -44,6 +44,8 @@
 			compatible = "ti,omap2-intc";
 			interrupt-controller;
 			#interrupt-cells = <1>;
+			ti,intc-size = <96>;
+			reg = <0x480FE000 0x1000>;
 		};
 
 		uart1: serial@4806a000 {
-- 
1.7.9.5

Re: [PATCH V2 1/2] arm/dts: OMAP2: Add support for OMAP2420 SDP

[Tony Lindgren]

* Jon Hunter <jon-hunter@ti.com> [120607 15:15]:
> Simple DTS file for OMAP2420 SDP adding memory information to allow device-tree
> testing on an OMAP2420 SDP.
> 
> Verified that kernel boots with DT using a simple RAMDISK file-system on
> OMAP2420 SDP.

I suspect this is the H4 board? If so, please rename it to H4 as it shares
the "debug board" with H2 and H3 so in theory we may at some point have
some common .dtsi for the debug board devices..

Regards,

Tony

Re: [PATCH V2 1/2] arm/dts: OMAP2: Add support for OMAP2420 SDP

[Jon Hunter]

On 06/12/2012 02:20 AM, Tony Lindgren wrote:
> * Jon Hunter <jon-hunter@ti.com> [120607 15:15]:
>> Simple DTS file for OMAP2420 SDP adding memory information to allow device-tree
>> testing on an OMAP2420 SDP.
>>
>> Verified that kernel boots with DT using a simple RAMDISK file-system on
>> OMAP2420 SDP.
> 
> I suspect this is the H4 board? If so, please rename it to H4 as it shares
> the "debug board" with H2 and H3 so in theory we may at some point have
> some common .dtsi for the debug board devices..

Yes, in fact I believe that 2420 SDP == H4 [1]. We appear to like
changing and chopping naming conventions at TI ;-)

I will update to H4 to be more consistent with the kernel naming.

Cheers
Jon

[1]
http://www.ti.com/general/docs/wtbu/wtbusplashcontent.tsp?templateId=6123&contentId=4750#omap2