From: Stephen Warren <swarren@wwwdotorg.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Rob Herring <robherring2@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
Grant Likely <grant.likely@secretlab.ca>,
mturquette@linaro.org, sboyd@codeaurora.org,
skannan@codeaurora.org, s.hauer@pengutronix.de,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH v3 0/4] DT clock bindings
Date: Fri, 15 Jun 2012 09:40:06 -0600 [thread overview]
Message-ID: <4FDB5756.3010402@wwwdotorg.org> (raw)
In-Reply-To: <20120615083937.GH31565@S2101-09.ap.freescale.net>
On 06/15/2012 02:39 AM, Shawn Guo wrote:
> On Tue, Jun 12, 2012 at 09:41:47AM -0500, Rob Herring wrote:
>> I'm posting this again to solicit further review. There has been some
>> discussion[1], but no definite path forward. This series is not changed
>> from the last post other than rebasing to v3.5-rc2.
>>
> Hi Rob,
>
> Per your comment[1], the patch below takes imx6q as example to define
> single CCM node with a whole bunch of outputs to support clk lookup
> with device tree. (Only uart and usdhc clocks are being put there for
> demonstration.) Though it seems working, going through the patch you
> will see a couple problems which may need to be solved to make the
> binding useful for cases like imx.
...
> * phandle argument is not easy for engineering
>
> As we will have a whole bunch of clock outputs listed in ccm node,
> which will be referenced by peripheral phandle in form of <&clks index>.
> When the list gets long, it becomes hard for people to find the correct
> index number for the clock referenced.
You can (well, probably /should/) list the clock IDs as well as names in
the binding documentation. Then, there's no guess-work or counting
involved. I did this in a very early Tegra clock binding proposal:
http://patchwork.ozlabs.org/patch/141359/
Hopefully, dtc will grow named-constants or a pre-processor sometime and
help this too.
next prev parent reply other threads:[~2012-06-15 15:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 14:41 [PATCH v3 0/4] DT clock bindings Rob Herring
2012-06-12 14:41 ` [PATCH v3 1/4] clk: add DT clock binding support Rob Herring
[not found] ` <1339512111-11172-2-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-06-15 3:17 ` Shawn Guo
2012-06-15 4:32 ` Rob Herring
2012-07-01 22:13 ` [PATCH v6] " Rob Herring
2012-06-12 14:41 ` [PATCH v3 2/4] clk: add DT fixed-clock " Rob Herring
2012-06-12 14:41 ` [PATCH v3 3/4] dt: add clock binding doc to primecell bindings Rob Herring
2012-06-12 14:41 ` [PATCH v3 4/4] clk: add highbank clock support Rob Herring
2012-06-12 15:47 ` [PATCH v3 0/4] DT clock bindings Mike Turquette
2012-06-12 16:23 ` Rob Herring
2012-06-14 8:49 ` Shawn Guo
2012-06-13 15:26 ` Peter De Schrijver
2012-06-13 18:09 ` Rob Herring
2012-06-15 8:39 ` Shawn Guo
2012-06-15 15:40 ` Stephen Warren [this message]
2012-06-15 21:07 ` Rob Herring
2012-06-21 7:27 ` Chris Ball
2012-06-21 7:30 ` [PATCH 01/02] clk: Refactor of_clk_* into a new clk-of.c Chris Ball
2012-06-21 7:32 ` [PATCH 02/02] clk: clk-of: Use alloc_bootmem() instead of kzalloc() Chris Ball
2012-06-21 12:18 ` Paul Mundt
2012-06-21 15:00 ` [PATCH v3 0/4] DT clock bindings Rob Herring
2012-06-21 17:54 ` Mike Turquette
2012-06-27 12:54 ` Rob Herring
2012-07-03 1:30 ` Turquette, Mike
2012-07-03 2:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDB5756.3010402@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@codeaurora.org \
--cc=shawn.guo@linaro.org \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).