devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "lrg@ti.com" <lrg@ti.com>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
	"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
	"sameo@linux.intel.com" <sameo@linux.intel.com>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] regulator: support for regulator match by regulator-compatible
Date: Tue, 19 Jun 2012 15:04:00 +0530	[thread overview]
Message-ID: <4FE04788.5040008@nvidia.com> (raw)
In-Reply-To: <20120619093211.GB3974@opensource.wolfsonmicro.com>

On Tuesday 19 June 2012 03:02 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Jun 19, 2012 at 11:21:26AM +0530, Laxman Dewangan wrote:
>> Add API to match the chip regulator's id by the
>> property of "regulator-compatible" on regulator node.
> We shouldn't have two different methods for doing this, we should
> standardise this over all regulator drivers (or at the very least those
> using the existing framework code) - having the old framework in place
> will at best be confusing for authors of new drivers.  We either need to
> make it clear which framework to use or (ideally) remove the old
> framework.

Agree. Currently following regulators are using this (based on grep)
mfd/tps6586x.c
regulator/ab8500.c
regulator/db8500-prcmu.c
and regulator/tps65910.

If the related change in tps65910 is fine and there is no more 
concern/feedback on the approach then I can create a series of patch to 
modify the other regulator and related dts file to follow the same.

If you want, I can make the new changes as part of this series or can 
start with new series.

I like to go with new series patch for other change once this is accepted.


  reply	other threads:[~2012-06-19  9:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19  5:51 [PATCH 0/2] regulator: tps65910: dt: identify regulator by prop regulator-compatible Laxman Dewangan
2012-06-19  5:51 ` [PATCH 1/2] regulator: support for regulator match by regulator-compatible Laxman Dewangan
2012-06-19  9:32   ` Mark Brown
2012-06-19  9:34     ` Laxman Dewangan [this message]
2012-06-19 10:43       ` Mark Brown
2012-06-19 10:37         ` Laxman Dewangan
2012-06-19 12:06         ` Laxman Dewangan
2012-06-19 12:18           ` Mark Brown
2012-06-19  5:51 ` [PATCH 2/2] regulator: tps65910: dt: identify regulator " Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE04788.5040008@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=sameo@linux.intel.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).