From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH v7] usb: chipidea: permit driver bindings pass phy pointer Date: Thu, 21 Jun 2012 22:42:52 +0200 Message-ID: <4FE3874C.2040504@pengutronix.de> References: <4FE2CABE.7050708@pengutronix.de> <1340268682-14654-1-git-send-email-richard.zhao@freescale.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig43E689FFA5BECF82A5945CD7" Return-path: In-Reply-To: <1340268682-14654-1-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Richard Zhao Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, marex-ynQEQJNshbs@public.gmane.org, B20596-KZfg59tc24xl57MIdRCFDg@public.gmane.org, dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org, alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, B29397-KZfg59tc24xl57MIdRCFDg@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: devicetree@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig43E689FFA5BECF82A5945CD7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 06/21/2012 10:51 AM, Richard Zhao wrote: > Sometimes, the driver bindings may know what phy they use. > For example, when using device tree, the usb controller may have a > phandler pointing to usb phy. Remove the module doesn't remove the platform device. A subsequent modpro= be fails with: ------------[ cut here ]------------ WARNING: at fs/sysfs/dir.c:529 sysfs_add_one+0x8c/0xbc() sysfs: cannot create duplicate filename '/devices/80080000.ahb/80080000.u= sb/ci_hdrc.0' Modules linked in: ci13xxx_imx(+) ci_hdrc udc_core [last unloaded: ci13xx= x_imx] [] (unwind_backtrace+0x0/0xf0) from [] (warn_slowpath= _common+0x4c/0x64) [] (warn_slowpath_common+0x4c/0x64) from [] (warn_slo= wpath_fmt+0x30/0x40) [] (warn_slowpath_fmt+0x30/0x40) from [] (sysfs_add_o= ne+0x8c/0xbc) [] (sysfs_add_one+0x8c/0xbc) from [] (create_dir+0x60= /0xc0) [] (create_dir+0x60/0xc0) from [] (sysfs_create_dir+0= x64/0xa8) [] (sysfs_create_dir+0x64/0xa8) from [] (kobject_add_= internal+0xa4/0x1e8) [] (kobject_add_internal+0xa4/0x1e8) from [] (kobject= _add+0x50/0x98) [] (kobject_add+0x50/0x98) from [] (device_add+0xb8/0= x358) [] (device_add+0xb8/0x358) from [] (platform_device_a= dd+0xf8/0x1a0) [] (platform_device_add+0xf8/0x1a0) from [] (ci13xxx_= add_device+0xd4/0x114 [ci_hdrc]) [] (ci13xxx_add_device+0xd4/0x114 [ci_hdrc]) from [] = (ci13xxx_imx_probe+0x1e0/0x288 [ci13xxx_imx]) [] (ci13xxx_imx_probe+0x1e0/0x288 [ci13xxx_imx]) from [] (platform_drv_probe+0x14/0x18) [] (platform_drv_probe+0x14/0x18) from [] (really_pro= be+0x68/0x1e0) [] (really_probe+0x68/0x1e0) from [] (__driver_attach= +0x8c/0x90) [] (__driver_attach+0x8c/0x90) from [] (bus_for_each_= dev+0x54/0x7c) [] (bus_for_each_dev+0x54/0x7c) from [] (bus_add_driv= er+0x17c/0x248) [] (bus_add_driver+0x17c/0x248) from [] (driver_regis= ter+0x78/0x12c) [] (driver_register+0x78/0x12c) from [] (do_one_initc= all+0x30/0x168) [] (do_one_initcall+0x30/0x168) from [] (sys_init_mod= ule+0x74/0x198) [] (sys_init_module+0x74/0x198) from [] (ret_fast_sys= call+0x0/0x2c) ---[ end trace e152599aa12f31d8 ]--- ------------[ cut here ]------------ WARNING: at lib/kobject.c:196 kobject_add_internal+0x1cc/0x1e8() kobject_add_internal failed for ci_hdrc.0 with -EEXIST, don't try to regi= ster things with the same name in the same directory. Modules linked in: ci13xxx_imx(+) ci_hdrc udc_core [last unloaded: ci13xx= x_imx] [] (unwind_backtrace+0x0/0xf0) from [] (warn_slowpath= _common+0x4c/0x64) [] (warn_slowpath_common+0x4c/0x64) from [] (warn_slo= wpath_fmt+0x30/0x40) [] (warn_slowpath_fmt+0x30/0x40) from [] (kobject_add= _internal+0x1cc/0x1e8) [] (kobject_add_internal+0x1cc/0x1e8) from [] (kobjec= t_add+0x50/0x98) [] (kobject_add+0x50/0x98) from [] (device_add+0xb8/0= x358) [] (device_add+0xb8/0x358) from [] (platform_device_a= dd+0xf8/0x1a0) [] (platform_device_add+0xf8/0x1a0) from [] (ci13xxx_= add_device+0xd4/0x114 [ci_hdrc]) [] (ci13xxx_add_device+0xd4/0x114 [ci_hdrc]) from [] = (ci13xxx_imx_probe+0x1e0/0x288 [ci13xxx_imx]) [] (ci13xxx_imx_probe+0x1e0/0x288 [ci13xxx_imx]) from [] (platform_drv_probe+0x14/0x18) [] (platform_drv_probe+0x14/0x18) from [] (really_pro= be+0x68/0x1e0) [] (really_probe+0x68/0x1e0) from [] (__driver_attach= +0x8c/0x90) [] (__driver_attach+0x8c/0x90) from [] (bus_for_each_= dev+0x54/0x7c) [] (bus_for_each_dev+0x54/0x7c) from [] (bus_add_driv= er+0x17c/0x248) [] (bus_add_driver+0x17c/0x248) from [] (driver_regis= ter+0x78/0x12c) [] (driver_register+0x78/0x12c) from [] (do_one_initc= all+0x30/0x168) [] (do_one_initcall+0x30/0x168) from [] (sys_init_mod= ule+0x74/0x198) [] (sys_init_module+0x74/0x198) from [] (ret_fast_sys= call+0x0/0x2c) ---[ end trace e152599aa12f31d9 ]--- imx_usb 80080000.usb: Can't register ci_hdrc platform device, err=3D-17 imx_usb: probe of 80080000.usb failed with error -17 Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enig43E689FFA5BECF82A5945CD7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/jh1AACgkQjTAFq1RaXHMjPgCgjWIt5r+y9VIJfQH52NaCUSnV JkUAn3tB5yrgYP2LkQmmzqzw3OR+uyKt =Xbtf -----END PGP SIGNATURE----- --------------enig43E689FFA5BECF82A5945CD7-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html