From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Subject: Re: [PATCH v5 1/7] ARM: davinci, cp_intc: Add irq domain support Date: Tue, 26 Jun 2012 08:54:05 +0200 Message-ID: <4FE95C8D.4000505@denx.de> References: <1338373143-7467-1-git-send-email-hs@denx.de> <1338373143-7467-2-git-send-email-hs@denx.de> <4FE89CCB.4090609@ti.com> Reply-To: hs-ynQEQJNshbs@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <4FE89CCB.4090609-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Sekhar Nori Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, Wolfgang Denk , Sergei Shtylyov , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hello Sekhar, On 25.06.2012 19:15, Sekhar Nori wrote: > Hi Heiko, > > On 5/30/2012 3:48 PM, Heiko Schocher wrote: >> Signed-off-by: Heiko Schocher >> Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org >> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org >> Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org >> Cc: Grant Likely >> Cc: Sekhar Nori >> Cc: Wolfgang Denk >> Cc: Sergei Shtylyov >> >> --- > > Applying this patch with two changes: > > 1) select IRQ_DOMAIN for CP_INTC arch/arm/mach-davinci/Kconfig. Without > this build breaks. > > 2) Add some commit description. For future, please have some commit > description on all patches. Ok. > I boot tested this on AM18x EVM. Also tested that GPIO interrupts are > not broken. Thanks! BTW: What is with the "rest" of the patches in this patchset? I got no more comments for them. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany