From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH v7 14/14] usb: chipidea: add imx platform driver Date: Wed, 27 Jun 2012 11:46:07 +0200 Message-ID: <4FEAD65F.5010106@pengutronix.de> References: <1340607391-16380-1-git-send-email-richard.zhao@freescale.com> <1340607391-16380-15-git-send-email-richard.zhao@freescale.com> <4FE83E96.5090004@pengutronix.de> <20120627062005.GB21750@b20223-02.ap.freescale.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigAA0446319B7B6020E7898B02" Return-path: In-Reply-To: <20120627062005.GB21750-iWYTGMXpHj9ITqJhDdzsOjpauB2SiJktrE5yTffgRl4@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Richard Zhao Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, B29397-KZfg59tc24xl57MIdRCFDg@public.gmane.org, B20596-KZfg59tc24xl57MIdRCFDg@public.gmane.org, marex-ynQEQJNshbs@public.gmane.org, shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org, dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, Peter Chen List-Id: devicetree@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAA0446319B7B6020E7898B02 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 06/27/2012 08:20 AM, Richard Zhao wrote: > On Mon, Jun 25, 2012 at 12:33:58PM +0200, Marc Kleine-Budde wrote: >> On 06/25/2012 08:56 AM, Richard Zhao wrote: >>> This patch supports only the host-mode functionality so far. >>> >>> Signed-off-by: Richard Zhao >>> Signed-off-by: Marek Vasut >>> Cc: Peter Chen >>> Cc: Alexander Shishkin >>> Cc: Felipe Balbi >>> Cc: Greg Kroah-Hartman >>> Tested-by: Subodh Nijsure >>> --- >>> .../devicetree/bindings/usb/ci13xxx-imx.txt | 20 ++ >>> drivers/usb/chipidea/Makefile | 3 + >>> drivers/usb/chipidea/ci13xxx_imx.c | 197 ++++++++++= ++++++++++ >>> 3 files changed, 220 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/usb/ci13xxx-imx= =2Etxt >>> create mode 100644 drivers/usb/chipidea/ci13xxx_imx.c >>> >>> diff --git a/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt b/= Documentation/devicetree/bindings/usb/ci13xxx-imx.txt >>> new file mode 100644 >>> index 0000000..8bcd071 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt >>> @@ -0,0 +1,20 @@ >>> +* Freescale i.MX ci13xxx usb controllers >>> + >>> +Required properties: >>> +- compatible: Should be "fsl,imx27-usb" >>> +- reg: Should contain registers location and length >>> +- interrupts: Should contain controller interrupt >>> + >>> +Optional properties: >>> +- fsl,usbphy: phandler of usb phy that connects to the only one port= >> >>> +- fsl,hub-reset-gpios: gpio used to reset on-board usb hub >>> +- fsl,vbus-power-gpios: gpio used to set vbus power of the only one = port >> >> These two properties are not implemented, are they? >> vbus is handled via a fixed regulator. > I forgot to update the doc. >> >> Further I'm looking into the phy and otg implementation. I think the >> handling of the regulator should go into mxs-phy.c, not into the >> ci13xxx_imx.c > Normally, we don't put it in phy driver. For example, most host driver > don't call phy drivers. Yes, I've noticed that otg support is ... a bit messy in the linux kernel. There are some drivers that implement a otg state machine. However, I have the udc on mx28 somewhat working. It's still a hack since I have to implement an otg driver for this, but the host part doesn't do otg so far...and unplug is not detected correctly. cheers, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enigAA0446319B7B6020E7898B02 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/q1mIACgkQjTAFq1RaXHPhBQCdE/UmLuGm9z3ay9Z/B7m1swRW fO0AnjF/rBcu2IGxZHRdWpGjU336S5+0 =Kyce -----END PGP SIGNATURE----- --------------enigAA0446319B7B6020E7898B02-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html