From: Roland Stigge <stigge@antcom.de>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
dwmw2@infradead.org, kevin.wells@nxp.com, srinivas.bakki@nxp.com,
linux-arm-kernel@lists.infradead.org, hechtb@googlemail.com,
lars@metafoo.de, b32955@freescale.com, leiwen@marvell.com,
linux@arm.linux.org.uk
Subject: Re: [PATCH v7] MTD: LPC32xx SLC NAND driver
Date: Wed, 27 Jun 2012 14:14:03 +0200 [thread overview]
Message-ID: <4FEAF90B.5030809@antcom.de> (raw)
In-Reply-To: <1340794007.29342.50.camel@sauron.fi.intel.com>
On 06/27/2012 12:46 PM, Artem Bityutskiy wrote:
> On Thu, 2012-06-07 at 12:22 +0200, Roland Stigge wrote:
>> This patch adds support for the SLC NAND controller inside the
>> LPC32xx SoC.
>>
>> Signed-off-by: Roland Stigge <stigge@antcom.de>
>
> Now the write_page and write_page_raw functions return an error
> code, see this commit in the l2 tree:
>
> http://git.infradead.org/users/dedekind/l2-mtd.git/commit/49c8d9ab3b70732665249f2d993f734378ebbba9
>
> I've amended your SLC driver, see below the diff. But I think it
> could return the real return code becuse it can fail - could you
> please take a look and send an incremental patch?
>
> Please, base your work on top of the l2-mtd tree:
> git://git.infradead.org/users/dedekind/l2-mtd.git
Thanks for the note! I'm sending an incremental patch. There was
actually only one place in the two functions that could fail (return
code of lpc32xx_xfer()).
Roland
next prev parent reply other threads:[~2012-06-27 12:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 10:22 [PATCH v7] MTD: LPC32xx SLC NAND driver Roland Stigge
[not found] ` <1339064536-20553-1-git-send-email-stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>
2012-06-07 10:22 ` [PATCH v6] MTD: LPC32xx MLC " Roland Stigge
2012-06-07 12:39 ` [PATCH v7] MTD: LPC32xx SLC " Artem Bityutskiy
2012-06-27 10:46 ` Artem Bityutskiy
2012-06-27 12:14 ` Roland Stigge [this message]
2012-06-27 12:26 ` Alexandre Pereira da Silva
[not found] ` <CAAAP30HemOV9svhVghLTWfZe95=P3CT-H7UsQ=xY6rC8=AfBsA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-27 15:25 ` Roland Stigge
2012-06-27 12:33 ` Artem Bityutskiy
2012-06-27 15:26 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEAF90B.5030809@antcom.de \
--to=stigge@antcom.de \
--cc=b32955@freescale.com \
--cc=dedekind1@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwmw2@infradead.org \
--cc=hechtb@googlemail.com \
--cc=kevin.wells@nxp.com \
--cc=lars@metafoo.de \
--cc=leiwen@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=srinivas.bakki@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).