* Re: [PATCH][Resend] of: Fix null pointer related warnings in base.c file
[not found] ` <1340770485-22670-1-git-send-email-sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2012-07-05 16:09 ` Rob Herring
0 siblings, 0 replies; only message in thread
From: Rob Herring @ 2012-07-05 16:09 UTC (permalink / raw)
To: Sachin Kamat
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
patches-QSEj5FYQhm4dnm+yROfE0A
On 06/26/2012 11:14 PM, Sachin Kamat wrote:
> Fixes the following sparse warnings:
> drivers/of/base.c:176:41: warning: Using plain integer as NULL pointer
> drivers/of/base.c:178:37: warning: Using plain integer as NULL pointer
> drivers/of/base.c:500:49: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Applied for 3.6.
Rob
> ---
> drivers/of/base.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index d9bfd49..2031aa1 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -173,9 +173,9 @@ struct property *of_find_property(const struct device_node *np,
> return NULL;
>
> read_lock(&devtree_lock);
> - for (pp = np->properties; pp != 0; pp = pp->next) {
> + for (pp = np->properties; pp; pp = pp->next) {
> if (of_prop_cmp(pp->name, name) == 0) {
> - if (lenp != 0)
> + if (lenp)
> *lenp = pp->length;
> break;
> }
> @@ -497,7 +497,7 @@ struct device_node *of_find_node_with_property(struct device_node *from,
> read_lock(&devtree_lock);
> np = from ? from->allnext : allnodes;
> for (; np; np = np->allnext) {
> - for (pp = np->properties; pp != 0; pp = pp->next) {
> + for (pp = np->properties; pp; pp = pp->next) {
> if (of_prop_cmp(pp->name, prop_name) == 0) {
> of_node_get(np);
> goto out;
>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-05 16:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1340770485-22670-1-git-send-email-sachin.kamat@linaro.org>
[not found] ` <1340770485-22670-1-git-send-email-sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-07-05 16:09 ` [PATCH][Resend] of: Fix null pointer related warnings in base.c file Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).