From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: bisected regression since 3.5-rc5 - hang on boot on some sparc64 machines Date: Tue, 10 Jul 2012 10:00:41 -0500 Message-ID: <4FFC4399.3050407@calxeda.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Meelis Roos , Linus Torvalds Cc: Thierry Reding , Linux Kernel list , Grant Likely , sparclinux@vger.kernel.org, devicetree-discuss@lists.ozlabs.org List-Id: devicetree@vger.kernel.org On 07/10/2012 06:09 AM, Meelis Roos wrote: > A regression since 3.5-rc5 stops Sun Fire V100 and Sun Netra X1 sparc64 > machines from booting, hanging after enabling serial console. Several > different other sparc64 systems work fine with 3.5-rc6. prtconf and full > dmesg below. > > Bisecting leads to > 107a84e61cdd3406c842a0e4be7efffd3a05dba6 is the first bad commit > commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6 > Author: Thierry Reding > Date: Thu Jun 14 09:12:35 2012 +0200 > > of: match by compatible property first > > When matching devices against an OF device ID table, the first string of > the compatible property that is listed in the table should match, > regardless of its position in the table. > > Cc: Grant Likely > Cc: Rob Herring > Cc: devicetree-discuss@lists.ozlabs.org > Signed-off-by: Thierry Reding > Signed-off-by: Rob Herring The problem is match combinations of compatible plus name and/or type fail to match correctly. I have a fix for this, but given how late it is for 3.5 I think it is best to revert this for now. There could be other cases that rely on the current although wrong behavior. I will post an updated version for 3.6. Linus, Please revert 107a84e61cdd3406c842a0e4be7efffd3a05dba6. Rob