Re: [PATCH v5 2/6] reset: imx8mp-audiomix: Replace mask with bit index

[Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>]

On 11/24/2025 7:41 AM, Frank Li wrote:
> On Mon, Nov 24, 2025 at 01:28:32AM -0800, Laurentiu Mihalcea wrote:
>> On 11/21/2025 7:38 AM, Frank Li wrote:
>>> On Fri, Nov 14, 2025 at 05:37:34AM -0800, Laurentiu Mihalcea wrote:
>>>> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>>>>
>>>> Replace the reset map mask with the bit index to make it clear that all
>>>> reset lines are managed by exactly 1 bit.
>>> I don't think there are benefit because I met some periphal need a magic
>>> number to reset.
>>
>> Please provide more information. What SoC? Which peripherals? What block control?
>>
> I can't reminder exact one. I grep some code
>
> [IMX8MP_MEDIABLK_PD_LCDIF_1] = {
>                 .name = "mediablk-lcdif-1",
>                 .clk_names = (const char *[]){ "disp1", "apb", "axi", },
>                 .num_clks = 3,
>                 .gpc_name = "lcdif1",
>                 .rst_mask = BIT(4) | BIT(5) | BIT(23),
>                 .clk_mask = BIT(4) | BIT(5) | BIT(23),
>                 .path_names = (const char *[]){"lcdif-rd", "lcdif-wr"},
>                 .num_paths = 2,
>         },
>
> mask is more extenable and easily support more hardware in future. Change
> to bit number have not big benefit.


sure, I'm fine with the mask-based approach. The big idea here is to make this driver

usable in as many scenarios as possible.


Philipp, please let me know if you're okay with the proposal. Will also have to tweak

one of the subsequent patches since, so far, we've been operating under the assumption

that reset lines are 1 bit.