* [PATCH] soc: mediatek: pm-domains: Fix the power glitch issue
@ 2022-10-14 10:20 Allen-KH Cheng
2022-10-14 10:30 ` AngeloGioacchino Del Regno
2022-11-22 17:38 ` Matthias Brugger
0 siblings, 2 replies; 4+ messages in thread
From: Allen-KH Cheng @ 2022-10-14 10:20 UTC (permalink / raw)
To: Matthias Brugger
Cc: angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
Chun-Jie Chen, Allen-KH Cheng
From: Chun-Jie Chen <chun-jie.chen@mediatek.com>
Power reset maybe generate unexpected signal. In order to avoid
the glitch issue, we need to enable isolation first to guarantee the
stable signal when power reset is triggered.
Fixes: 59b644b01cf4 ("soc: mediatek: Add MediaTek SCPSYS power domains")
Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
---
Resend a PATCH from
https://patchwork.kernel.org/project/linux-mediatek/patch/20220310011548.2487-1-chun-jie.chen@mediatek.com/
[Allen-KH Cheng <allen-kh.cheng@mediatek.com>]
---
---
drivers/soc/mediatek/mtk-pm-domains.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c
index 09e3c38b8466..474b272f9b02 100644
--- a/drivers/soc/mediatek/mtk-pm-domains.c
+++ b/drivers/soc/mediatek/mtk-pm-domains.c
@@ -275,9 +275,9 @@ static int scpsys_power_off(struct generic_pm_domain *genpd)
clk_bulk_disable_unprepare(pd->num_subsys_clks, pd->subsys_clks);
/* subsys power off */
- regmap_clear_bits(scpsys->base, pd->data->ctl_offs, PWR_RST_B_BIT);
regmap_set_bits(scpsys->base, pd->data->ctl_offs, PWR_ISO_BIT);
regmap_set_bits(scpsys->base, pd->data->ctl_offs, PWR_CLK_DIS_BIT);
+ regmap_clear_bits(scpsys->base, pd->data->ctl_offs, PWR_RST_B_BIT);
regmap_clear_bits(scpsys->base, pd->data->ctl_offs, PWR_ON_2ND_BIT);
regmap_clear_bits(scpsys->base, pd->data->ctl_offs, PWR_ON_BIT);
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] soc: mediatek: pm-domains: Fix the power glitch issue
2022-10-14 10:20 [PATCH] soc: mediatek: pm-domains: Fix the power glitch issue Allen-KH Cheng
@ 2022-10-14 10:30 ` AngeloGioacchino Del Regno
2022-11-15 9:09 ` Allen-KH Cheng (程冠勳)
2022-11-22 17:38 ` Matthias Brugger
1 sibling, 1 reply; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-14 10:30 UTC (permalink / raw)
To: Allen-KH Cheng, Matthias Brugger
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, Chun-Jie Chen
Il 14/10/22 12:20, Allen-KH Cheng ha scritto:
> From: Chun-Jie Chen <chun-jie.chen@mediatek.com>
>
> Power reset maybe generate unexpected signal. In order to avoid
> the glitch issue, we need to enable isolation first to guarantee the
> stable signal when power reset is triggered.
>
> Fixes: 59b644b01cf4 ("soc: mediatek: Add MediaTek SCPSYS power domains")
> Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: mediatek: pm-domains: Fix the power glitch issue
2022-10-14 10:30 ` AngeloGioacchino Del Regno
@ 2022-11-15 9:09 ` Allen-KH Cheng (程冠勳)
0 siblings, 0 replies; 4+ messages in thread
From: Allen-KH Cheng (程冠勳) @ 2022-11-15 9:09 UTC (permalink / raw)
To: matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Chun-Jie Chen (陳浚桀),
Project_Global_Chrome_Upstream_Group, devicetree@vger.kernel.org
Hey maintainer,
Gentle ping for this one.
Cheers,
Allen
On Fri, 2022-10-14 at 12:30 +0200, AngeloGioacchino Del Regno wrote:
> Il 14/10/22 12:20, Allen-KH Cheng ha scritto:
> > From: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> >
> > Power reset maybe generate unexpected signal. In order to avoid
> > the glitch issue, we need to enable isolation first to guarantee
> > the
> > stable signal when power reset is triggered.
> >
> > Fixes: 59b644b01cf4 ("soc: mediatek: Add MediaTek SCPSYS power
> > domains")
> > Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> > Reviewed-by: Miles Chen <miles.chen@mediatek.com>
>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: mediatek: pm-domains: Fix the power glitch issue
2022-10-14 10:20 [PATCH] soc: mediatek: pm-domains: Fix the power glitch issue Allen-KH Cheng
2022-10-14 10:30 ` AngeloGioacchino Del Regno
@ 2022-11-22 17:38 ` Matthias Brugger
1 sibling, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2022-11-22 17:38 UTC (permalink / raw)
To: Allen-KH Cheng
Cc: angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
Chun-Jie Chen
On 14/10/2022 12:20, Allen-KH Cheng wrote:
> From: Chun-Jie Chen <chun-jie.chen@mediatek.com>
>
> Power reset maybe generate unexpected signal. In order to avoid
> the glitch issue, we need to enable isolation first to guarantee the
> stable signal when power reset is triggered.
>
> Fixes: 59b644b01cf4 ("soc: mediatek: Add MediaTek SCPSYS power domains")
> Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
Applied to fixes now, thanks!
> ---
> Resend a PATCH from
> https://patchwork.kernel.org/project/linux-mediatek/patch/20220310011548.2487-1-chun-jie.chen@mediatek.com/
>
> [Allen-KH Cheng <allen-kh.cheng@mediatek.com>]
> ---
> ---
> drivers/soc/mediatek/mtk-pm-domains.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c
> index 09e3c38b8466..474b272f9b02 100644
> --- a/drivers/soc/mediatek/mtk-pm-domains.c
> +++ b/drivers/soc/mediatek/mtk-pm-domains.c
> @@ -275,9 +275,9 @@ static int scpsys_power_off(struct generic_pm_domain *genpd)
> clk_bulk_disable_unprepare(pd->num_subsys_clks, pd->subsys_clks);
>
> /* subsys power off */
> - regmap_clear_bits(scpsys->base, pd->data->ctl_offs, PWR_RST_B_BIT);
> regmap_set_bits(scpsys->base, pd->data->ctl_offs, PWR_ISO_BIT);
> regmap_set_bits(scpsys->base, pd->data->ctl_offs, PWR_CLK_DIS_BIT);
> + regmap_clear_bits(scpsys->base, pd->data->ctl_offs, PWR_RST_B_BIT);
> regmap_clear_bits(scpsys->base, pd->data->ctl_offs, PWR_ON_2ND_BIT);
> regmap_clear_bits(scpsys->base, pd->data->ctl_offs, PWR_ON_BIT);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-22 17:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-14 10:20 [PATCH] soc: mediatek: pm-domains: Fix the power glitch issue Allen-KH Cheng
2022-10-14 10:30 ` AngeloGioacchino Del Regno
2022-11-15 9:09 ` Allen-KH Cheng (程冠勳)
2022-11-22 17:38 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).