devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution
@ 2017-08-17  7:49 Icenowy Zheng
       [not found] ` <20170817074926.3410-1-icenowy-h8G6r0blFSE@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Icenowy Zheng @ 2017-08-17  7:49 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Icenowy Zheng

Q8 tablets with Allwinner A33 SoC now come with two kind of LCD, either
800x480 or 1024x600.

In order for sun4i-drm to be able to choose correct LCD configuration,
two different device trees should be present, one for a resolution.

Add stub device trees for two resolutions.

As the sun4i-drm driver still has some problems to support the LCDs, the
real LCD device nodes are not added to the device tree files.

Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
---
 arch/arm/boot/dts/Makefile                         |  2 +
 arch/arm/boot/dts/sun8i-a33-q8-tablet-1024x600.dts | 49 ++++++++++++++++++++++
 arch/arm/boot/dts/sun8i-a33-q8-tablet-800x480.dts  | 49 ++++++++++++++++++++++
 3 files changed, 100 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun8i-a33-q8-tablet-1024x600.dts
 create mode 100644 arch/arm/boot/dts/sun8i-a33-q8-tablet-800x480.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 570e107bf702..eeb9d9591cf0 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -908,6 +908,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \
 	sun8i-a33-ippo-q8h-v1.2.dtb \
 	sun8i-a33-olinuxino.dtb \
 	sun8i-a33-q8-tablet.dtb \
+	sun8i-a33-q8-tablet-800x480.dtb \
+	sun8i-a33-q8-tablet-1024x600.dtb \
 	sun8i-a33-sinlinx-sina33.dtb \
 	sun8i-a83t-allwinner-h8homlet-v2.dtb \
 	sun8i-a83t-cubietruck-plus.dtb \
diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet-1024x600.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet-1024x600.dts
new file mode 100644
index 000000000000..6f8ebd6c90ee
--- /dev/null
+++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet-1024x600.dts
@@ -0,0 +1,49 @@
+/*
+ * Copyright 2017 Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "sun8i-a33-q8-tablet.dts"
+
+/ {
+	model = "Q8 A33 Tablet with 1024x600 LCD";
+	compatible = "allwinner,q8-a33-1024x600", "allwinner,q8-a33",
+		     "allwinner,sun8i-a33";
+};
diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet-800x480.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet-800x480.dts
new file mode 100644
index 000000000000..ad84b94dee53
--- /dev/null
+++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet-800x480.dts
@@ -0,0 +1,49 @@
+/*
+ * Copyright 2017 Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "sun8i-a33-q8-tablet.dts"
+
+/ {
+	model = "Q8 A33 Tablet with 800x480 LCD";
+	compatible = "allwinner,q8-a33-800x480", "allwinner,q8-a33",
+		     "allwinner,sun8i-a33";
+};
-- 
2.13.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution
       [not found] ` <20170817074926.3410-1-icenowy-h8G6r0blFSE@public.gmane.org>
@ 2017-08-21  8:40   ` Maxime Ripard
       [not found]     ` <20170821084053.s4qmhlvgsmckmqgh-ZC1Zs529Oq4@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2017-08-21  8:40 UTC (permalink / raw)
  To: Icenowy Zheng
  Cc: Chen-Yu Tsai, devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

On Thu, Aug 17, 2017 at 03:49:26PM +0800, Icenowy Zheng wrote:
> Q8 tablets with Allwinner A33 SoC now come with two kind of LCD, either
> 800x480 or 1024x600.
> 
> In order for sun4i-drm to be able to choose correct LCD configuration,
> two different device trees should be present, one for a resolution.
> 
> Add stub device trees for two resolutions.
> 
> As the sun4i-drm driver still has some problems to support the LCDs, the
> real LCD device nodes are not added to the device tree files.
> 
> Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>

This should be an overlay, ideally applied by the bootloader.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution
       [not found]     ` <20170821084053.s4qmhlvgsmckmqgh-ZC1Zs529Oq4@public.gmane.org>
@ 2017-08-21  8:44       ` icenowy-h8G6r0blFSE
       [not found]         ` <4a0a72b4679db296a8e48512c41a2ce5-h8G6r0blFSE@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: icenowy-h8G6r0blFSE @ 2017-08-21  8:44 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Chen-Yu Tsai,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

在 2017-08-21 16:40,Maxime Ripard 写道:
> On Thu, Aug 17, 2017 at 03:49:26PM +0800, Icenowy Zheng wrote:
>> Q8 tablets with Allwinner A33 SoC now come with two kind of LCD, 
>> either
>> 800x480 or 1024x600.
>> 
>> In order for sun4i-drm to be able to choose correct LCD configuration,
>> two different device trees should be present, one for a resolution.
>> 
>> Add stub device trees for two resolutions.
>> 
>> As the sun4i-drm driver still has some problems to support the LCDs, 
>> the
>> real LCD device nodes are not added to the device tree files.
>> 
>> Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
> 
> This should be an overlay, ideally applied by the bootloader.

I think this is not suitable for overlay.

The two kind of Q8 tablets are not compatible at all, and they
should both have a suitable device tree. The old DT without
resolution is only kept for backward compatibility.

> 
> Maxime
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution
       [not found]         ` <4a0a72b4679db296a8e48512c41a2ce5-h8G6r0blFSE@public.gmane.org>
@ 2017-08-22 20:33           ` Maxime Ripard
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2017-08-22 20:33 UTC (permalink / raw)
  To: icenowy-h8G6r0blFSE
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Chen-Yu Tsai,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

On Mon, Aug 21, 2017 at 04:44:30PM +0800, icenowy-h8G6r0blFSE@public.gmane.org wrote:
> 在 2017-08-21 16:40,Maxime Ripard 写道:
> > On Thu, Aug 17, 2017 at 03:49:26PM +0800, Icenowy Zheng wrote:
> > > Q8 tablets with Allwinner A33 SoC now come with two kind of LCD,
> > > either
> > > 800x480 or 1024x600.
> > > 
> > > In order for sun4i-drm to be able to choose correct LCD configuration,
> > > two different device trees should be present, one for a resolution.
> > > 
> > > Add stub device trees for two resolutions.
> > > 
> > > As the sun4i-drm driver still has some problems to support the LCDs,
> > > the
> > > real LCD device nodes are not added to the device tree files.
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
> > 
> > This should be an overlay, ideally applied by the bootloader.
> 
> I think this is not suitable for overlay.
> 
> The two kind of Q8 tablets are not compatible at all, and they
> should both have a suitable device tree.

How are they not compatible?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-08-22 20:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-17  7:49 [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution Icenowy Zheng
     [not found] ` <20170817074926.3410-1-icenowy-h8G6r0blFSE@public.gmane.org>
2017-08-21  8:40   ` Maxime Ripard
     [not found]     ` <20170821084053.s4qmhlvgsmckmqgh-ZC1Zs529Oq4@public.gmane.org>
2017-08-21  8:44       ` icenowy-h8G6r0blFSE
     [not found]         ` <4a0a72b4679db296a8e48512c41a2ce5-h8G6r0blFSE@public.gmane.org>
2017-08-22 20:33           ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).