From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 963FDC4332F for ; Fri, 21 Oct 2022 12:59:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229752AbiJUM7z (ORCPT ); Fri, 21 Oct 2022 08:59:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbiJUM7y (ORCPT ); Fri, 21 Oct 2022 08:59:54 -0400 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA6DF38A22 for ; Fri, 21 Oct 2022 05:59:49 -0700 (PDT) Received: by mail-qv1-xf2b.google.com with SMTP id i12so1756409qvs.2 for ; Fri, 21 Oct 2022 05:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xs86T8FYH3cxwsGgQStZ75SdWF5yjS9RigXMT2iDTuI=; b=raelHNIqjAfNIduVyyhSmxlkeTmBDWI5M6eoHxEOrDyKvgNyTbqt/BRWMPAC4nyTU/ +RIcoIbxCOd1bCVzg0ez40BfCEH8TH5rbH/1bKbuWoMDp9xT+/XTptK0PvMHZJMCBOFo tdhKqlH3KQJEvM5sQlNYiMBPzVTM4IIBtCbGm7COkFrpRtKe2PJ0lybfPAALCxS3bMia DNJoHxnwgLylRFQfjoTP96dCa7nKWqblDqBC6IG/Fofgnzwn+v1y0EgrqueYHx+2FQX6 W45YOl3lHnGDZ3YWK12yIQL7vxtLoElGLygLUlaxImLD83SnzCSpERJZLHW0JoEs9BEl JuXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xs86T8FYH3cxwsGgQStZ75SdWF5yjS9RigXMT2iDTuI=; b=KLv3fRAjhjnhh2fwnacIa8LdyIXmIZEo9dL9MaaHiwEnQ2THhOlZO7nN2lifTll+W0 yUtniLIIUFjJkxJWwYrXfii24qdFTL8ifz3X6fWkOIIJAhMy+Iw+VpJHsXNN59yb4ZNU 2V1JoGHlKHVis/ztQjFgMIDGarpNPi4KCFqe//iKJo6A9WV6xhE3GJZV666UGLh6KG8Q SjlY4gKbX9VOj7PS1dUx2xW+ho0HUJ/i+XidKoiA/DZd+QNNT+KIO3YY8JrlggqTURFk 3bLr90m5FNKgENYGwo+6hajVruwUgMxXNqdNgr7x9o0FNiJmll+Fpf7/B2qhCg/bl64C q+CQ== X-Gm-Message-State: ACrzQf23kiwQvPHCTO+u43TfSpMg9q9tVmgcn0opekDI1Sg3Istzw2RR wx+GiXHsve0dwz1HYibk7SHGRQ== X-Google-Smtp-Source: AMsMyM4j88gzow5EGAxNNk2ntX3Dfj86V9wgcexSHaNsAvEEmqSEG+IUzLHqUnaYykHbSpgJR0l5pw== X-Received: by 2002:a05:6214:1c89:b0:4af:664e:553b with SMTP id ib9-20020a0562141c8900b004af664e553bmr16626198qvb.18.1666357188296; Fri, 21 Oct 2022 05:59:48 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id bn4-20020a05622a1dc400b0039ccbf75f92sm7884973qtb.11.2022.10.21.05.59.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Oct 2022 05:59:47 -0700 (PDT) Message-ID: <4a0b2e54-e13c-d6e8-261a-a282f35c1a30@linaro.org> Date: Fri, 21 Oct 2022 08:59:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v3 1/2] spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states Content-Language: en-US To: Amjad Ouled-Ameur , neil.armstrong@linaro.org, Mark Brown , Krzysztof Kozlowski , Jerome Brunet , Martin Blumenstingl , Kevin Hilman , Rob Herring Cc: Da Xue , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221004-up-aml-fix-spi-v3-0-89de126fd163@baylibre.com> <20221004-up-aml-fix-spi-v3-1-89de126fd163@baylibre.com> <20c115e0-0acf-dac2-2a30-0f394fa513ab@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/10/2022 08:54, Amjad Ouled-Ameur wrote: > Hi > > On 10/20/22 14:49, Krzysztof Kozlowski wrote: >>>>> + properties: >>>>> + pinctrl-names: >>>>> + minItems: 1 >>>>> + items: >>>>> + - const: default >>>>> + - const: idle-high >>>>> + - const: idle-low >>>> You should also define in such case pinctrl-0 and others. >>> Ok I thought it would be covered by the pinctrl-consumer.yaml >>> but yeah we should allow pinctrl-1 and pinctrl-2 here aswell by adding: >>> >>> pinctrl-1: true >>> pinctrl-2: true >>> >>> > In such case, should I define pinctrl- as part of the if statement, as shown below, > > or before allOf ? The same as pinctrl-names, so part of allOf. > > [...] > >   - if: >       properties: >         compatible: >           contains: >             enum: >               - amlogic,meson-gx-spicc > >     then: >       properties: >         pinctrl-0: true >         pinctrl-1: true >         pinctrl-2: true > >         pinctrl-names: >           minItems: 1 >           items: >             - const: default >             - const: idle-high >             - const: idle-low Best regards, Krzysztof