From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Animesh Agarwal <animeshagarwal28@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: rename wm8750.yaml to wlf,wm8750.yaml
Date: Thu, 20 Jun 2024 08:59:54 +0200 [thread overview]
Message-ID: <4a1c65e3-4508-4c7e-ae91-0ff0ef7a6c74@kernel.org> (raw)
In-Reply-To: <ebebb17c-0247-4328-8129-24f15ef6f5c4@kernel.org>
On 20/06/2024 08:37, Krzysztof Kozlowski wrote:
> On 20/06/2024 08:08, Daniel Baluta wrote:
>> On Wed, Jun 19, 2024 at 10:29 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>
>>> On 19/06/2024 09:03, Animesh Agarwal wrote:
>>>> Add vendor prefix to wlf,wm8750 dt-schema.
>>>>
>>>> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
>>>> Cc: Daniel Baluta <daniel.baluta@nxp.com>
>>>> ---
>>>> .../devicetree/bindings/sound/{wm8750.yaml => wlf,wm8750.yaml} | 2 +-
>>>
>>> Same as in other cases (why they started now?): why only one file not
>>> all of them? Anyway, that's not necessary.
>>
>> There is only one yaml file from wolfson which doesnt have the wlf, prefix.
>> For consistency we think that we should rename the file :).
>
> And several other files have the same issue. That's just churn. No, let
> me be clear. Rule is for all files, not for wlf or asahi only. If you
> want that consistency, then fix *all* files, not selected one schema.
I see now Kuninori went by my previous suggestion, so this patch is not
needed/obsolete.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-06-20 7:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 7:03 [PATCH] ASoC: dt-bindings: rename wm8750.yaml to wlf,wm8750.yaml Animesh Agarwal
2024-06-19 7:26 ` Krzysztof Kozlowski
2024-06-20 6:08 ` Daniel Baluta
2024-06-20 6:37 ` Krzysztof Kozlowski
2024-06-20 6:59 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a1c65e3-4508-4c7e-ae91-0ff0ef7a6c74@kernel.org \
--to=krzk@kernel.org \
--cc=animeshagarwal28@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).