devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Lamparter <christian.lamparter@isd.uni-stuttgart.de>
To: Robert Marko <robimarko@gmail.com>,
	kvalo@kernel.org, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	jjohnson@kernel.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	ath11k@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels
Date: Fri, 12 Apr 2024 21:52:01 +0200	[thread overview]
Message-ID: <4a1e0cb6-c319-4eb1-9bd1-5ff13eabfe1b@isd.uni-stuttgart.de> (raw)
In-Reply-To: <20240412162510.29483-2-robimarko@gmail.com>

On 4/12/24 6:24 PM, Robert Marko wrote:
> The common DT property can be used to limit the available channels
> but ath11k has to manually call wiphy_read_of_freq_limits().
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>

I've seen this before.

https://patchwork.kernel.org/project/linux-wireless/patch/ed266944c721de8dbf0fe35f387a3a71b2c84037.1686486468.git.chunkeey@gmail.com/

(dt-binding too. it has/had an ack)
https://patchwork.kernel.org/project/linux-wireless/patch/fc606d2550d047a53b4289235dd3c0fe23d5daac.1686486468.git.chunkeey@gmail.com/

sooo.... this is awkward.

> ---
>   drivers/net/wireless/ath/ath11k/mac.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
> index c32be587000d..59bde128d351 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -10124,6 +10124,7 @@ static int __ath11k_mac_register(struct ath11k *ar)
>   	if (ret)
>   		goto err;
>   
> +	wiphy_read_of_freq_limits(ar->hw->wiphy);
>   	ath11k_mac_setup_ht_vht_cap(ar, cap, &ht_cap);
>   	ath11k_mac_setup_he_cap(ar, cap);
>   


  reply	other threads:[~2024-04-12 19:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12 16:24 [PATCH 1/2] dt-bindings: net: wireless: ath11k: add ieee80211-freq-limit property Robert Marko
2024-04-12 16:24 ` [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels Robert Marko
2024-04-12 19:52   ` Christian Lamparter [this message]
2024-04-12 20:21     ` Robert Marko
2024-04-12 20:53     ` Jeff Johnson
2024-04-15 16:06       ` Kalle Valo
2024-04-15 16:08         ` Robert Marko
2024-04-16 13:21 ` [PATCH 1/2] dt-bindings: net: wireless: ath11k: add ieee80211-freq-limit property Rob Herring
2024-04-16 13:22   ` Robert Marko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a1e0cb6-c319-4eb1-9bd1-5ff13eabfe1b@isd.uni-stuttgart.de \
    --to=christian.lamparter@isd.uni-stuttgart.de \
    --cc=ath11k@lists.infradead.org \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=jjohnson@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=robimarko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).