From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82CB818EFC5 for ; Tue, 18 Jun 2024 11:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718708800; cv=none; b=VD43G4/cJcTSQsYtBDt2xv8ZB4s4krVCYenabqZqpWVS7WE0OnFSvDlWAgPggfSPpnYKoU9V6JOIxHfANBXtSPZ2FPTP/zUUMZ9QZq+YwGidiW11pS6nqEpEicN7o66OrlJle0x54ewhEt5gm9wppFhxdoIdtHDNk7xIxsv8EmI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718708800; c=relaxed/simple; bh=Am09hb5rNTES561xMQzEHkDAVY5vO4Ar4tuZXHwiN+w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qCtkzQO/i88ACNYV/WGj9WeJyVrA96I/042TkYBzuTtMmujWhD4jTVQhT+p29mizXnXawlPx76KYklHMNoNOAemCIdAAeSQUKdyjcfbbl5pW7mNhVHFgPikdXlEia4QO4Jd01DGmS0I1BoKqTKf/xZzvec+T0cy2efj036Pp3d8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=h64uMDcJ; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h64uMDcJ" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2ebe6495aedso50234971fa.0 for ; Tue, 18 Jun 2024 04:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718708797; x=1719313597; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=107/jrO9V2OrXrc4KAyCZ+/nIEIgm16zwlwCoHMLHyg=; b=h64uMDcJdXAwrqKuowtt4Mc4+GocEaoB2P1kqSIzyzd6W1wE7uOP6hMyZ4rrJBRtuz /xXk3ITFbQwA2Z7/5Vz4EowB4kPlb7mDWbNTP3ANIoOwYOd2/3CQAG0OIw/zuu73BZJ9 0nMjs3nAoBwmq0DGvn8BxvZKCOgNO973nO+LCtx4ERxw5cJ9MPSOFScOX4MVX+T/4Yjn GzQCpxnaE2FAEgMfeSII19ohSqmyMG5za0uf6wScJYrnx2vlQuNRp2k2TVYeQhgTXkW+ ez1z0YqKagAOM7b1c6bP2J2qPaanvwF3NQq3LQOVcxJCF4eOCTli7VCmLJfZ5OjNMtP5 mF9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718708797; x=1719313597; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=107/jrO9V2OrXrc4KAyCZ+/nIEIgm16zwlwCoHMLHyg=; b=GWLPbOKCYCZlRHIq31CWjrX80sxfGjRi0qWII2pVX+kR7rN/uZVY0xd5O578L3xIZD NtuU3lyps4obiJAMa3YC7d1Ma/xRFIqoQElikGaKXH23ppXwe0iAWXs+Szqm8JVrx7zW VZaxHMWQu7sOIFiEGNvruoNXNTvx7jPsDd4XfrUHlPrziyzA6bA/zNfuD1aj5I/kKR76 uNuHzty/jszJDjE/a+JPCrnw0i9AWH8G5d9Vbd+J8psEUgPVj1NXifuD4ylllcVRaABc 7GVejHzHm9IMKeX5GweG3iJELUvBWFjxbwZWK/fZKX1EBZGXxBdmxGXDA728sgjfKDmi VjoQ== X-Forwarded-Encrypted: i=1; AJvYcCV8ZP/heelMDPxLrRAmHX2XdvwEEz6XvnQ5SNorovQrQxOrV17ZfNFPJED9m9DbIBfz9ZvLBNGkrYedWT1EPXfKMQnpBu5IqZMgAg== X-Gm-Message-State: AOJu0YzHYljK20fgEzgfDQKeU+5PiwAoCPb5VwswqOtPnpJw8vEEiZM6 ly8wauxt3jrUwwiN33Qwin6exzcoNPBSlfwLhRfuu/U5esIuZhgpwcoAGL6szC4= X-Google-Smtp-Source: AGHT+IFcmeQiuUo4eYmQs8GBtVAruWPttXXbgsv4+msDs3zvTSjrD3ETiEcpx4MmCotUTolyCbWZiA== X-Received: by 2002:a2e:97d0:0:b0:2eb:ea64:1934 with SMTP id 38308e7fff4ca-2ec0e60d0e8mr70677581fa.49.1718708796685; Tue, 18 Jun 2024 04:06:36 -0700 (PDT) Received: from ?IPV6:2a00:f41:9028:9df3:4fb7:492b:2c94:7283? ([2a00:f41:9028:9df3:4fb7:492b:2c94:7283]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ec2d25ad22sm6255991fa.86.2024.06.18.04.06.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jun 2024 04:06:36 -0700 (PDT) Message-ID: <4a1e8cc5-5d82-435d-8a2a-5fab56f85965@linaro.org> Date: Tue, 18 Jun 2024 13:06:34 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: qcom: x1e80100: Enable tsens and thermal zone nodes To: Abel Vesa , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak References: <20240614-x1e80100-dts-thermal-v2-1-4d4f9effacc6@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240614-x1e80100-dts-thermal-v2-1-4d4f9effacc6@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/14/24 12:50, Abel Vesa wrote: > From: Rajendra Nayak > > Add tsens and thermal zones nodes for x1e80100 SoC. > > Signed-off-by: Rajendra Nayak > Signed-off-by: Abel Vesa > --- [...] > + tsens0: thermal-sensor@c271000 { > + compatible = "qcom,x1e80100-tsens", "qcom,tsens-v2"; > + reg = <0 0x0c271000 0 0x1000>, > + <0 0x0c222000 0 0x1000>; > + > + interrupts = , > + ; These are normally wired up through PDC so that the system can shut down even if CPUSS is off [...] > + cpu0-0-top-thermal { > + thermal-sensors = <&tsens0 1>; Here you have passive trip points with no passive polling, this will only report threshold crossing events (so e.g. cpufreq throttling will be broken) > + > + trips { > + trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + trip-point1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu-critical { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + [...] > + > + nsp1-thermal { > + polling-delay-passive = <10>; Here you have passive polling, but no passive trip point > + > + thermal-sensors = <&tsens3 2>; > + > + trips { > + trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "hot"; > + }; > + > + nsp1-critical { > + temperature = <125000>; > + hysteresis = <0>; > + type = "critical"; > + }; > + }; > + }; The rest looks okayish Konrad