From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D94C76196 for ; Fri, 31 Mar 2023 09:00:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231797AbjCaJAx (ORCPT ); Fri, 31 Mar 2023 05:00:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231708AbjCaJAt (ORCPT ); Fri, 31 Mar 2023 05:00:49 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE8CB46A1 for ; Fri, 31 Mar 2023 02:00:35 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id l12so21636470wrm.10 for ; Fri, 31 Mar 2023 02:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680253234; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=4nQxeJeXLAS1yXrHfRZgden2oQvmJ5Y9pjAachYDoZ8=; b=Rfekt0B+9GcLek7jW9pdK9C1nrTpK/XO63FVs0kWMDI5v92l510njwVLFzcTfuNy+e aPvLB9GcI83JEBBGZe/Jyw+qV6BywO88PArPxQJB6+QFugl+XaEatn4d3umC0stKVGyt Ttp65Pj8/BRs+eT1Aejcl6TLwpDDS/JloMzMIrZLZJNugidEBrFDVP8LWnzS9bDb+Txp 9qRh97w8EUdr1zZZNCzE872PvRwyXLl81Neqi6pSMFhbKSjh4z7CTS0Gvn2DzYaHadPZ zeL3fbjd7nuFEV5lqH+D3qz4uuDn6CgUXNGcEh5oqhHCvHOgCFL0RmrF1kgE3DN0GwCG i7kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680253234; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4nQxeJeXLAS1yXrHfRZgden2oQvmJ5Y9pjAachYDoZ8=; b=yuzWGzwsOFH60jNIyihKIYzv6ZbX60FqT/tr497KJeUT7Rw25oOii47d8LoOi6t6Bn 5QSG9MzGqEzcWaMLM5ASNPbUmqyYCUqyzWDbYtWG6kjF3ki2iGCYwm6lWr/6BSWHZR1H aQh/1HUPjyEN2CKS5cj0wHbXpgscPrabo6MLl6suUOplSlsiU9Gdwl+vJbT91/d+J2KS YPjsoc0I061XXusWF2wKeS3LHKvT7clgw6QFGX0GvK75Wa/Xy0Hxodpx0uToCfARO3xv XIUF9sTcHwxTXmnp/s6BqgQ9QyX5rbb9/NzgN2DZZG/Q+0Yyx4pC9XSUl+UUrWWbdGwt XTUQ== X-Gm-Message-State: AAQBX9cLdl+Bh0PNgFMxw8nAFhCZ6qjHgNNyS34GCVzltPBCY5qM582c AiqqR4TW0Os8mscWF2bkbT+Oug== X-Google-Smtp-Source: AKy350Z55GTUKlJlEyylgRJXO0eyo6+oSEbH6wjS3e2bsKEghN79AAf836I98UmhXi41vJrW7Wd7SA== X-Received: by 2002:adf:f703:0:b0:2cf:ea38:ef29 with SMTP id r3-20020adff703000000b002cfea38ef29mr20498270wrp.44.1680253234309; Fri, 31 Mar 2023 02:00:34 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:74cb:1a96:c994:e7e0? ([2a01:e0a:982:cbb0:74cb:1a96:c994:e7e0]) by smtp.gmail.com with ESMTPSA id n5-20020adffe05000000b002d97529b3bbsm1619283wrr.96.2023.03.31.02.00.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 02:00:34 -0700 (PDT) Message-ID: <4a22e085-b339-aa43-518e-d528c5f76de4@linaro.org> Date: Fri, 31 Mar 2023 11:00:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v3 2/3] drm/bridge: tfp410: Fix logic to configured polled HPD Content-Language: en-US To: Jonathan Cormier , Andrzej Hajda , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Williamson , Bob Duke References: <20230125-tfp410_i2c-v3-0-a85d5f0f50f1@criticallink.com> <20230125-tfp410_i2c-v3-2-a85d5f0f50f1@criticallink.com> Organization: Linaro Developer Services In-Reply-To: <20230125-tfp410_i2c-v3-2-a85d5f0f50f1@criticallink.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On 20/02/2023 23:10, Jonathan Cormier wrote: > From: Michael Williamson > > The logic to configure polling (vs async/irq notification) of hot-plug > events was not correct. If the connected bridge requires polling, > then inform the upstream bridge we also require polling. > > Signed-off-by: Michael Williamson > Signed-off-by: Jonathan Cormier > --- > drivers/gpu/drm/bridge/ti-tfp410.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c > index bb3f8d0ff207..41007d05d584 100644 > --- a/drivers/gpu/drm/bridge/ti-tfp410.c > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c > @@ -155,7 +155,7 @@ static int tfp410_attach(struct drm_bridge *bridge, > return -ENODEV; > } > > - if (dvi->next_bridge->ops & DRM_BRIDGE_OP_DETECT) > + if (dvi->next_bridge->ops & DRM_BRIDGE_OP_HPD) > dvi->connector.polled = DRM_CONNECTOR_POLL_HPD; > else > dvi->connector.polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT; > A Fixes tag is probably needed here ? With that: Reviewed-by: Neil Armstrong