From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BBBEC46467 for ; Sat, 26 Nov 2022 19:04:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229551AbiKZTEC (ORCPT ); Sat, 26 Nov 2022 14:04:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbiKZTEB (ORCPT ); Sat, 26 Nov 2022 14:04:01 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DFB115823 for ; Sat, 26 Nov 2022 11:03:59 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id f13so11527478lfa.6 for ; Sat, 26 Nov 2022 11:03:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xJpb+WkZomiEzVr3FB9WEc1c2EffiMVPclC8fGlh3s8=; b=dJgBE61y1TEmCKX4hb3KjCC5icYw0Rjg5nXCZ8mYvHKGctBqvJN8rZATLAR1yQEnjC Sj2cN7RDvYRRE/War1xcr8lYTXHbs3Psnuq/vWD5tE4I8eI6dgfpi8E0lfomzrmWU6sZ 2dE6Nbr5P2Tc92US/3araYp2EOh42i9T2C4t+AD2IS58hrmctQN+Cfg35OhC89KV6nuq sOEHmvct96WKxyM7JvA4rYNGLNZZwaWB0SScG44WRu2nS+kE7KPhUZz+TLijpLGD0T6I 5OOPFMmGhZDcXOQo4q5FmqQ0YpZUpflmtaLvpkhGR0b1q81ZCj1EcLNMD5binun0hcxX XomA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xJpb+WkZomiEzVr3FB9WEc1c2EffiMVPclC8fGlh3s8=; b=Gd8NFOuhSVib7uW9EmH8v2vMTxqMWrMRc3jO0Si0F5k8apwIJlQgNgrnnAFUbbwNzt CkQFo2JWM2c2eXUQmSpzTwuwOdIl5qvybzwHRopf3N/xqbiw0Ps37vGFM5oIKk/6yEKm 4dWcUXqC0BmhjzhfxctW1qhfoZsrhb5gfZVwx6zKjALhw+KX4cKXZMP9SPOxsaYZY+vM pFnprwudLGBJvGpArFN7eju51f2mQv59MIFWs6EmS7Q+iOCTit/+MVL/hq+cs678+6lq 6pK0I6JT7hqW2izD0Ruc9El4soZdTGsFeR9lalBEE7vz937SCli5mloVd1hI3bcfuBYI 59yw== X-Gm-Message-State: ANoB5pmC2lpQMuu2j6cLNv6ydsAIHozlvryQvxIP6gEZjktXyQLSJ3tN PyxQxQ4GGMpYUDzauEJHPqoezw== X-Google-Smtp-Source: AA0mqf513EmQbR4frhOdq/bbbyDNS7W6KiUDqApBp0la6BHiUOGHcbkMtbdFVBN2q5QtFbEZzZ00vQ== X-Received: by 2002:ac2:4d44:0:b0:4b1:2aab:7cc0 with SMTP id 4-20020ac24d44000000b004b12aab7cc0mr9740288lfp.553.1669489437839; Sat, 26 Nov 2022 11:03:57 -0800 (PST) Received: from [192.168.1.8] ([185.24.52.156]) by smtp.gmail.com with ESMTPSA id b29-20020a0565120b9d00b004946e72711bsm998920lfv.76.2022.11.26.11.03.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Nov 2022 11:03:57 -0800 (PST) Message-ID: <4a2a36ee-85d3-bf6d-ec19-87a89831f67e@linaro.org> Date: Sat, 26 Nov 2022 21:03:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v4 16/18] arm64: dts: qcom: sdm660: Add compat qcom,sdm660-dsi-ctrl Content-Language: en-GB To: Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: robdclark@gmail.com, quic_abhinavk@quicinc.com, sean@poorly.run, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, dianders@chromium.org, david@ixit.cz, krzysztof.kozlowski+dt@linaro.org, swboyd@chromium.org, konrad.dybcio@somainline.org, agross@kernel.org, andersson@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221125123638.823261-1-bryan.odonoghue@linaro.org> <20221125123638.823261-17-bryan.odonoghue@linaro.org> From: Dmitry Baryshkov In-Reply-To: <20221125123638.823261-17-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/11/2022 14:36, Bryan O'Donoghue wrote: > Add silicon specific compatible qcom,sdm660-dsi-ctrl to the > mdss-dsi-ctrl block. This allows us to differentiate the specific bindings > for sdm660 against the yaml documentation. > > Signed-off-by: Bryan O'Donoghue > --- > arch/arm64/boot/dts/qcom/sdm660.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm660.dtsi b/arch/arm64/boot/dts/qcom/sdm660.dtsi > index 10bf1c45cf6ec..f8ec728e67f3d 100644 > --- a/arch/arm64/boot/dts/qcom/sdm660.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm660.dtsi > @@ -154,7 +154,8 @@ mdp5_intf2_out: endpoint { > > &mdss { > dsi1: dsi@c996000 { > - compatible = "qcom,mdss-dsi-ctrl"; > + compatible = "qcom,sdm660-dsi-ctrl", > + "qcom,mdss-dsi-ctrl"; So, we'd end up with two identical DSI hosts, but one has compatible 'qcom,sdm660-dsi-ctrl' and another one 'qcom,sdm630-dsi-ctrl'. I think, use sdm660 for both of them (for both sdm630 and sdm660) > reg = <0x0c996000 0x400>; > reg-names = "dsi_ctrl"; > -- With best wishes Dmitry