From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dan Murphy <dmurphy@ti.com>
Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] can: tcan4x5x: Turn on the power before parsing the config
Date: Thu, 2 Jan 2020 13:38:55 +0100 [thread overview]
Message-ID: <4a2e80f0-13c5-df7b-65af-25f86ca48f2a@pengutronix.de> (raw)
In-Reply-To: <20191210163204.28225-1-dmurphy@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1162 bytes --]
On 12/10/19 5:32 PM, Dan Murphy wrote:
> The parse config function now performs action on the device either
> reading or writing and a reset. If the regulator is managed it needs
> to be turned on. So turn on the regulator if available if the parsing
> fails then turn off the regulator.
Another BTW:
Consider converting the switching of the vsup to runtime_pm.
Yet another one:
Why do you disable the clocks in the error path of tcan4x5x_can_probe(),
but never enable them?
> out_clk:
> if (!IS_ERR(mcan_class->cclk)) {
> clk_disable_unprepare(mcan_class->cclk);
> clk_disable_unprepare(mcan_class->hclk);
> }
- please move the clock handling from the m_can.c to the individual
driver
- please move the clock handling to runtime_pm in the individual driver
- remove the obsolete m_can_class_get_clocks()
- make runtime_pm mandatory
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-02 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 16:32 [PATCH v2] can: tcan4x5x: Turn on the power before parsing the config Dan Murphy
2019-12-10 16:46 ` Marc Kleine-Budde
2020-01-02 11:11 ` Marc Kleine-Budde
2020-01-02 12:38 ` Marc Kleine-Budde [this message]
2020-01-24 19:50 ` Dan Murphy
2020-01-31 17:27 ` Dan Murphy
2020-01-02 14:40 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a2e80f0-13c5-df7b-65af-25f86ca48f2a@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).