From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC95219755B for ; Tue, 7 Oct 2025 14:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759846286; cv=none; b=nDFr3sKeKVbYhlDDqezACtPkJKeXSZQLBN6pad8sYEwYUHITxne5cM/q/D2F83h1xbN6ezVmYQm80Uu+w9qRQNhlkeedKDqJVlnG3DcvhTkIqbR+AsVwnIblZXoWh8rE2EKJbz9ZmsZU4oDHcAKgBIpbawfpk2jdpHElOMm2Eko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759846286; c=relaxed/simple; bh=5wQfQwqYI2fZ4w1KXVMOyK6TI0qttDsdvBxjxVjo+ns=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sDK2lAUJDolRlsVsSnDhNYjD1ASYKSuzE+f8awqDR+XuhD9gthSJrEiElLzQ1A+6dq/g3GiBsVvOETYFSjHbMJ4sHqrflZvRf/bxhi8o32sVpXp7Zp/sqJU75Sz4JipVJtI/DlULgdSI4LWnkPJIpHRXV+EiorjyM9Nzs8OVwEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RCNjlgwf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RCNjlgwf" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 597BoJBF017633 for ; Tue, 7 Oct 2025 14:11:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ktSaSroeEeu0/UwzC26whCkkXqXo9Ky2cJhuhNttXgY=; b=RCNjlgwfOop7gG5d arwVlWqSWExlXBE6AuPhk+OBM/Fi3R2S05wbdkdR11TQlbTGttahPn4eJx5RVywe rQ0LKj+G0QTwoIEYLDRU+sTorcqIZhyO1GDBKiHzUSH7kXgW2rlVhuK8pLN6oQZi 4VRmdeEKvYRlue5bjWQqHZ1VNxjmx7nfF4AFYRCjSl2UN++KPN8YXZaP1N0IBU1V TQRvLb98F3O3c6SBcwn0UsAeJylMkjWshN8YO/S410q8JUv8Qp10ihZUAz9j5JQ8 M404ZUaj6jOK4Hj2B062p6BD89kZ/9PESg0Rw35r/tT+0JqO5hYG4WKMwqAcADu4 0sNCAA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49jvrhq8cw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 07 Oct 2025 14:11:23 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7810e5a22f3so10745298b3a.1 for ; Tue, 07 Oct 2025 07:11:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759846283; x=1760451083; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ktSaSroeEeu0/UwzC26whCkkXqXo9Ky2cJhuhNttXgY=; b=LJtf2EJn6dybWCPJc68yxVr4wtR4GO3Y8pOcTLhmcsPQv49sumNmq4LZfUoNRZgf4f MMJ3bnM5IYOVGHtBTa1oZ1JnYBYk2WYZZeK4pjIidMe/wZfLePwXNS8F/GC1oIfLkYCT Wt8PGicf/8zq4ICAnUTexXvJCE8vnTGdAAtxapzr2Bl+73Rh4Td3vSPYP2wmowEBfuu8 AOd+4Hbr9+VzcdWt742cq3O2JywUIFLnAftC+/fXevTCEFn6MHiVKwkKtgz6cFpKGbyG j9BXQ976ms6F7oUvfVBiJXrjRin/46NsIL4idjyfpdgcFpdtOlA/f+IBiHkvMMQTg1p/ CNtQ== X-Forwarded-Encrypted: i=1; AJvYcCXKif9iDmNX65fNYDq0OpPHrPhmzdRAOTBIBOnRFuOkN/6tNjDuJQu/jHvnZKpsmAy1lbtmVypIdHdf@vger.kernel.org X-Gm-Message-State: AOJu0YxBlBxbrFtcMGlBYTnFspVwhpr3xFiQ+9yekF5re65swck3bYu/ TcyV+qx6qGRgDgCVHlDhB1GBF6cnfnkdvdYHH/f6+nwicINAM76h+RPNrT83JEWTD7++Acz23bs jzVHqX4PPGVJ971/td0WnYT8zrrXxUjI23L2Ut7IXs5yZ4IJQDgpz9A9AHNG7sB99 X-Gm-Gg: ASbGncuFXZGjUGIjbb6Fj7qkRDLwuju1Pv1aHyOgHcMnAUXEGVY2kMvC4vcJkrMZQma kR3pRLOauPCTs3Ltcy29OKgsOcBkUmUEMOX14PSMn43Xyan0Dehp0vDfzfSOisjjYEXtz9ik1HU 3eREE0bHYdlLgKgQaKKSq+JjUXaWf5hC4GP6aU0RH0QgnQo/BP666Xzh1gBYsEx+FyEgiBk2cZk k8T76Mn1Lr9ygJPvDJr07iufUaDDdFANnxWlI3AzCd+EnYxBHK/LWYkGvYFHsH+0oNyCDz+YDoo 6ERo+o2e7WxEyKknaw5KR2RLKN+0LoHHkv7D1YDlwUPF9/R8+J3iMElwLVRWtm0pVHlhf2Tbnw= = X-Received: by 2002:a05:6a21:998e:b0:302:9f3b:3e5c with SMTP id adf61e73a8af0-32b620a8d65mr21677927637.39.1759846282881; Tue, 07 Oct 2025 07:11:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGiWYBtr6EzAYm3iarthma/0DUKSsRzYme+v56XXtnu78Nq/GDSGSQ38ocKvh8T4EgfkEtS3g== X-Received: by 2002:a05:6a21:998e:b0:302:9f3b:3e5c with SMTP id adf61e73a8af0-32b620a8d65mr21677873637.39.1759846282301; Tue, 07 Oct 2025 07:11:22 -0700 (PDT) Received: from [10.219.56.14] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b6099d4cfbesm15316893a12.28.2025.10.07.07.11.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Oct 2025 07:11:21 -0700 (PDT) Message-ID: <4a32bbec-2baf-4210-a7c1-1ddcd45d30c8@oss.qualcomm.com> Date: Tue, 7 Oct 2025 19:41:16 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/5] Introduce "non-pixel" sub node within iris video node To: Dmitry Baryshkov , Bryan O'Donoghue Cc: Konrad Dybcio , Krzysztof Kozlowski , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <7b6db4fa-2f73-376d-4eb3-64c1c7e6cda3@quicinc.com> <5qsgbqml367yq6g5vb4lotrzulojqhi5zlwwribze373a63qrn@rxi4kwyt66m2> <4f38058d-a2f1-4ac5-b234-228cfb2e85ff@kernel.org> <1ad2ca1e-1d57-4ad8-a057-ab0d804f1d49@oss.qualcomm.com> <7da769b4-88e9-401f-bb21-0ff123818b9c@kernel.org> <6840d462-8269-4359-a6e5-d154842b62db@oss.qualcomm.com> <2hh3zkdwgqbdurpr4tibr3gjat6arwl3dd3gxakdaagafwjdrm@aj5em4tbsjen> Content-Language: en-US From: Charan Teja Kalla In-Reply-To: <2hh3zkdwgqbdurpr4tibr3gjat6arwl3dd3gxakdaagafwjdrm@aj5em4tbsjen> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDA0MDAzNiBTYWx0ZWRfXyjeWUJ8Yi846 f/FtA7nFkrHI3iQxZjs80xcRpLEHx+JhxF6T7X7Ym6mV/q4B8hxA+ihLgFmrr2Pl4ljabO31YB9 3zQwV4RfTQUvza2VHwIYgwOELfckt9B6QhNDkqRBj+Uv5/bNC8f4lQzm7R6F6Z69IXb7it+PJq9 XODfzQEXd23y7vmkilijWXPRCiSFzJ9HjMEpAfVNIr8ZrVyWgTtNRmWugUzIvA52kbX/AMJmJbU ZZ0KSSs9gNjvObCpXSFTGCeCCbcqc2lgRcROHaXkSp18EaS48OtaP7bDAJwy11imQa2PqYEQHGw pFT6OwdpTKKhaj+GFT4SpISKMG3t4VQ46zHB6YpP7UJI3/jUoEXuoMSotSOem/as8QD7VKy4Stt +g0qcBHUtXXIoAeSCJFs+9O3HmDLRA== X-Proofpoint-GUID: -xomPHXJq0rG7QoJ26NNzkbCclsMwGbn X-Authority-Analysis: v=2.4 cv=XIQ9iAhE c=1 sm=1 tr=0 ts=68e51f8b cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=XxnNId_WCiCfXLSGgVMA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: -xomPHXJq0rG7QoJ26NNzkbCclsMwGbn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-07_01,2025-10-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 clxscore=1015 adultscore=0 spamscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2510040036 On 7/4/2025 10:15 PM, Dmitry Baryshkov wrote: > On Fri, Jul 04, 2025 at 09:23:06AM +0100, Bryan O'Donoghue wrote: >> On 03/07/2025 22:23, Dmitry Baryshkov wrote: >>>> I still give my RB for the series. >>>> >>>> To me the only question is should it be applied to sm8550 or to new SoCs >>>> from now on, sa8775p, x1e and derivatives. >>> I think we need to apply it to_all_ SoCs, maybe starting from MSM8x26 >>> and MSM8x16. Likewise, we need to think bout secure buffers usecase. And >>> once we do that, we will realize that it also changes the ABI for all >>> SoCs that support either Venus or Iris. >> I think a dts change is a non-starter as its an ABI break. >> >> So if ABI break is out and reworking future dts to allow for a new device is >> out, then some API change is needed to allow the driver to stop the kernel >> automatically setting up the IOMMUs, create the new device as a platform >> device not dependent on DT change and have the probe() of the relevant >> drivers setup their own IOMMU extents based on - probably indexes we have in >> the driver configuration parameters. > > What about instead: > > - keep IOMMU entries as is > - Add iommu-maps, mapping the non-pixel SID Otherways to avoid the ABI breakage: a) Keep iommus max items as 2, which is unchanged. b) Repeat the same sid for both entries, i.e., iommus = <&apps_smmu 0x1940 0x0000>, - <&apps_smmu 0x1947 0x0000>; + <&apps_smmu 0x1940 0x0000>; and then create the new device as a platform device independent of dt. RFC for this is posted[1]. However, Dmitry(in offline forums) termed creating 2 same sid entries as -- "ridiculous band-aid just to fulfill the "ABI" requirements and really doesn't make sense". Looks Fair. OTOH, To exactly implement the idea mentioned here, I have the below questions, can you please help me with: 1) By keeping the entries in 'iommu=' as is, then add non-pixel sid in iommu-maps actually creates the overlapping entries. So, IIUC -- this requires changes to the iommu driver to ignore the setting up the non-pixel sid(or whatever is mentioned in iommu-maps) and then use newly created platform device to program the entries mentioned in iommu-maps. Please CMIW. If the above understanding correct -- Doesn't it look like we are trying to fix in the iommu driver for the problem statement related to dt bindings? 2) However, I still think that problem statement of __non-eligibility for video IP to create the sub devices in the dt__ is still valid and can be taken separately and actually [1] is targetting this. I believe this is atleast required for secure contexts. please CMIW. [1] https://lore.kernel.org/all/20250928171718.436440-1-charan.kalla@oss.qualcomm.com/ Thanks, Charan> - In future expand iommu-maps, describing the secure contexts?