[PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split)

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split)
@ 2023-07-13 15:29 ` Krzysztof Kozlowski
  2023-07-13 15:29   ` [PATCH 2/2] ARM: dts: samsung: s5pv210-smdkv210: " Krzysztof Kozlowski
                     ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-13 15:29 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Alim Akhtar, Rob Herring, Conor Dooley,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel

The davicom,dm9000 Ethernet Controller accepts two reg addresses.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/samsung/s3c6410-mini6410.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts b/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
index 17097da36f5e..0b07b3c31960 100644
--- a/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
+++ b/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
@@ -51,7 +51,7 @@ srom-cs1-bus@18000000 {
 
 		ethernet@18000000 {
 			compatible = "davicom,dm9000";
-			reg = <0x18000000 0x2 0x18000004 0x2>;
+			reg = <0x18000000 0x2>, <0x18000004 0x2>;
 			interrupt-parent = <&gpn>;
 			interrupts = <7 IRQ_TYPE_LEVEL_HIGH>;
 			davicom,no-eeprom;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: dts: samsung: s5pv210-smdkv210: correct ethernet reg addresses (split)
  2023-07-13 15:29 ` [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split) Krzysztof Kozlowski
@ 2023-07-13 15:29   ` Krzysztof Kozlowski
  2023-07-14 10:27     ` Alim Akhtar
  2023-07-14 10:26   ` [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: " Alim Akhtar
  2023-07-19  7:36   ` Krzysztof Kozlowski
  2 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-13 15:29 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Alim Akhtar, Rob Herring, Conor Dooley,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel

The davicom,dm9000 Ethernet Controller accepts two reg addresses.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts b/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
index 6e26c67e0a26..901e7197b136 100644
--- a/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
+++ b/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
@@ -41,7 +41,7 @@ pmic_ap_clk: clock-0 {
 
 	ethernet@a8000000 {
 		compatible = "davicom,dm9000";
-		reg = <0xA8000000 0x2 0xA8000002 0x2>;
+		reg = <0xa8000000 0x2>, <0xa8000002 0x2>;
 		interrupt-parent = <&gph1>;
 		interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
 		local-mac-address = [00 00 de ad be ef];
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* RE: [PATCH 2/2] ARM: dts: samsung: s5pv210-smdkv210: correct ethernet reg addresses (split)
  2023-07-13 15:29   ` [PATCH 2/2] ARM: dts: samsung: s5pv210-smdkv210: " Krzysztof Kozlowski
@ 2023-07-14 10:27     ` Alim Akhtar
  0 siblings, 0 replies; 6+ messages in thread
From: Alim Akhtar @ 2023-07-14 10:27 UTC (permalink / raw)
  To: 'Krzysztof Kozlowski', 'Rob Herring',
	'Conor Dooley', linux-arm-kernel, linux-samsung-soc,
	devicetree, linux-kernel



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Thursday, July 13, 2023 8:59 PM
> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; Rob Herring <robh+dt@kernel.org>; Conor
> Dooley <conor+dt@kernel.org>; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH 2/2] ARM: dts: samsung: s5pv210-smdkv210: correct ethernet
> reg addresses (split)
> 
> The davicom,dm9000 Ethernet Controller accepts two reg addresses.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Do you need to add fixes: to send to previous stable releases?
In any case:
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>


>  arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
> b/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
> index 6e26c67e0a26..901e7197b136 100644
> --- a/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
> +++ b/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
> @@ -41,7 +41,7 @@ pmic_ap_clk: clock-0 {
> 
>  	ethernet@a8000000 {
>  		compatible = "davicom,dm9000";
> -		reg = <0xA8000000 0x2 0xA8000002 0x2>;
> +		reg = <0xa8000000 0x2>, <0xa8000002 0x2>;
>  		interrupt-parent = <&gph1>;
>  		interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
>  		local-mac-address = [00 00 de ad be ef];
> --
> 2.34.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split)
  2023-07-13 15:29 ` [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split) Krzysztof Kozlowski
  2023-07-13 15:29   ` [PATCH 2/2] ARM: dts: samsung: s5pv210-smdkv210: " Krzysztof Kozlowski
@ 2023-07-14 10:26   ` Alim Akhtar
  2023-07-16 17:38     ` Krzysztof Kozlowski
  2023-07-19  7:36   ` Krzysztof Kozlowski
  2 siblings, 1 reply; 6+ messages in thread
From: Alim Akhtar @ 2023-07-14 10:26 UTC (permalink / raw)
  To: 'Krzysztof Kozlowski', 'Rob Herring',
	'Conor Dooley', linux-arm-kernel, linux-samsung-soc,
	devicetree, linux-kernel

Hello Krzysztof

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Thursday, July 13, 2023 8:59 PM
> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; Rob Herring <robh+dt@kernel.org>; Conor
> Dooley <conor+dt@kernel.org>; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet
> reg addresses (split)
> 
> The davicom,dm9000 Ethernet Controller accepts two reg addresses.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Do you need to add fixes: to send to previous stable releases?
In any case:

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/samsung/s3c6410-mini6410.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
> b/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
> index 17097da36f5e..0b07b3c31960 100644
> --- a/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
> +++ b/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
> @@ -51,7 +51,7 @@ srom-cs1-bus@18000000 {
> 
>  		ethernet@18000000 {
>  			compatible = "davicom,dm9000";
> -			reg = <0x18000000 0x2 0x18000004 0x2>;
> +			reg = <0x18000000 0x2>, <0x18000004 0x2>;
>  			interrupt-parent = <&gpn>;
>  			interrupts = <7 IRQ_TYPE_LEVEL_HIGH>;
>  			davicom,no-eeprom;
> --
> 2.34.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split)
  2023-07-14 10:26   ` [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: " Alim Akhtar
@ 2023-07-16 17:38     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-16 17:38 UTC (permalink / raw)
  To: Alim Akhtar, 'Rob Herring', 'Conor Dooley',
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel

On 14/07/2023 12:26, Alim Akhtar wrote:
> Hello Krzysztof
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Thursday, July 13, 2023 8:59 PM
>> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Alim Akhtar
>> <alim.akhtar@samsung.com>; Rob Herring <robh+dt@kernel.org>; Conor
>> Dooley <conor+dt@kernel.org>; linux-arm-kernel@lists.infradead.org; linux-
>> samsung-soc@vger.kernel.org; devicetree@vger.kernel.org; linux-
>> kernel@vger.kernel.org
>> Subject: [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet
>> reg addresses (split)
>>
>> The davicom,dm9000 Ethernet Controller accepts two reg addresses.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
> Do you need to add fixes: to send to previous stable releases?
> In any case:


The format was actually working, but indeed it makes sense to backport
it. I'll add it when applying.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split)
  2023-07-13 15:29 ` [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split) Krzysztof Kozlowski
  2023-07-13 15:29   ` [PATCH 2/2] ARM: dts: samsung: s5pv210-smdkv210: " Krzysztof Kozlowski
  2023-07-14 10:26   ` [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: " Alim Akhtar
@ 2023-07-19  7:36   ` Krzysztof Kozlowski
  2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-19  7:36 UTC (permalink / raw)
  To: Alim Akhtar, Rob Herring, Conor Dooley, linux-arm-kernel,
	linux-samsung-soc, devicetree, linux-kernel, Krzysztof Kozlowski


On Thu, 13 Jul 2023 17:29:25 +0200, Krzysztof Kozlowski wrote:
> The davicom,dm9000 Ethernet Controller accepts two reg addresses.
> 
> 

Applied, thanks!

[1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split)
      https://git.kernel.org/krzk/linux/c/cf0cb2af6a18f28b84f9f1416bff50ca60d6e98a
[2/2] ARM: dts: samsung: s5pv210-smdkv210: correct ethernet reg addresses (split)
      https://git.kernel.org/krzk/linux/c/982655cb0e7f18934d7532c32366e574ad61dbd7

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-07-19  7:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20230713152937epcas5p483e95ece242b0dc2c9a1ada1ba328117@epcas5p4.samsung.com>
2023-07-13 15:29 ` [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split) Krzysztof Kozlowski
2023-07-13 15:29   ` [PATCH 2/2] ARM: dts: samsung: s5pv210-smdkv210: " Krzysztof Kozlowski
2023-07-14 10:27     ` Alim Akhtar
2023-07-14 10:26   ` [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: " Alim Akhtar
2023-07-16 17:38     ` Krzysztof Kozlowski
2023-07-19  7:36   ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).