From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4518D41C6D for ; Fri, 21 Jun 2024 12:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718974297; cv=none; b=BGagXuaxTj1sHDU6aV6gUyDpZ6wUUV61+l+j0ZkzkVi1QAH9ZTEOpIexScz059h27cTw9jj/THlY7hnvoTk1NEScCb6ymGxQC1SFg36MdRBsKgyV1UaKo8Z12Udlq+oX7KoIq6LsYBeyTjqHQQCP6vhaqRYuHSz4749JsK3hPmI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718974297; c=relaxed/simple; bh=oJhNKSiOdLm70pBsH/9KJGUC8653wDVYRRmce2De8Bg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZKO/i6H/BeHa75xJy1+TpDpWMYUDV7cKzccU7z7jsjEa+Lr2cLchfYSrfRX003Bfs4JQkNX7JjQVnDEdMqYUCibNfxrjmut8YE3V2te9fRSH2WSjIIvaERQ37wcuOI9TY82PtPImgtxAtj2DN7ndbSq2gcw8Fwb0BFcZo0wBGZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=F0dZIvhJ; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="F0dZIvhJ" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-52c82101407so3377027e87.3 for ; Fri, 21 Jun 2024 05:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1718974293; x=1719579093; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FWAkuQtQbhgbJxkwJNkctDpDNqgcetuxscd31qCmfLE=; b=F0dZIvhJpOCGe4xldY+ZYegvpouhxyghVn5/vNu96mXxPlMDcUqH9dy6OKGPlQNwT4 +oBVU6pxz16AlG00wX8Z01/U9b2lkVM+KE8pUbUt7QchJ1jcAAQxVHVQJIzKie29IDFd 0ubL0NBLjzybnktvGU9N7cC/3ILhrsZh9lsv/mCji3ekcFuYwB+GGQTTA2GakuaqKJtB CBLxjcSNDza8perAqeDJf0dBRat2q0B+ZkQqfAoEjwUJPpALqKnfLVZVLVNT6pDZdf73 L0h5hMh9zBX56sB/nLOKVT33cP24/PusfjvBoeZbprt9hyjGswhNAcNq1RNYW1HfozXs 5FMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718974293; x=1719579093; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FWAkuQtQbhgbJxkwJNkctDpDNqgcetuxscd31qCmfLE=; b=kRT2UqGZWYNQAt+Gndbhl7menZcdkX1PsGB44/k21FIYutl1S9dJboUk5Gy5ln5MC2 41LWSs373zl1v8NjmcyhZ5cv61ApBj/6RZFJ4y+3lJRe+sMHHSM6ewsEvnSlwM+BPnH1 NAhsAsha368R8m2SA5dGD3DOynDCSj8DLQHnjwIAGY3FO7RUao79BU215kXl7xN5Kbtx fYQ1nrLtqlSsl1IYyErXqrQ3Bjo7WUBe1Bulip1yOTgiDSlmv6cqreEK13EJPxZOyO40 fcFuKUgvgy5tJqYpRwY++oh9noKmn2hLLBVVqp91wQ9SoD9vl3iWiGzmTrmMfk8PuigN Uhtw== X-Forwarded-Encrypted: i=1; AJvYcCV4r6QOPtAec9TMz4VQo5Z8RQBTOJE2vFFBBqIYjZUYDio9andQ+pW724Kh014ACfhLs3I0Q+rcmHSW+HfXTMUADS3ZouUAgULcmg== X-Gm-Message-State: AOJu0Yw5Xuw+h5Is37bw5n2aKT9ynThFmZu7cA+tMNP6MyZFfyufX404 3PMySOto8aG/s3ZuDVVRINfWfUnw+ugumDrG40QOH+2Q49/OA+gXGTjm6NRuVe0= X-Google-Smtp-Source: AGHT+IGGZCHswcYDLs1QtSATkylyIC1UJHcz54PWiA9XC+0LCqDJPsD4911wb1Jx40wbuOCUR3XASw== X-Received: by 2002:a05:6512:3706:b0:52b:be6b:d16a with SMTP id 2adb3069b0e04-52ccaa36508mr5286238e87.31.1718974293312; Fri, 21 Jun 2024 05:51:33 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.70]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6fcf560627sm82273966b.148.2024.06.21.05.51.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jun 2024 05:51:32 -0700 (PDT) Message-ID: <4a693c1f-15ec-43b4-8f53-ab0a6bd4d7dc@tuxon.dev> Date: Fri, 21 Jun 2024 15:51:28 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/12] i2c: riic: Add suspend/resume support Content-Language: en-US To: Biju Das , Chris Brandt , "andi.shyti@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "geert+renesas@glider.be" , "magnus.damm@gmail.com" , "mturquette@baylibre.com" , "sboyd@kernel.org" , "p.zabel@pengutronix.de" , "wsa+renesas@sang-engineering.com" Cc: "linux-renesas-soc@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , Claudiu Beznea References: <20240621112303.1607621-1-claudiu.beznea.uj@bp.renesas.com> <20240621112303.1607621-7-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21.06.2024 15:30, Biju Das wrote: > Hi Claudiu, > > Thanks for the patch > >> -----Original Message----- >> From: Claudiu >> Sent: Friday, June 21, 2024 12:23 PM >> Subject: [PATCH 06/12] i2c: riic: Add suspend/resume support >> >> From: Claudiu Beznea >> >> Add suspend/resume support for the RIIC driver. This is necessary for the Renesas RZ/G3S SoC which >> support suspend to deep sleep state where power to most of the SoC components is turned off. As a >> result the I2C controller needs to be reconfigured after suspend/resume. For this, the reset line >> was stored in the driver private data structure as well as i2c timings. >> The reset line and I2C timings are necessary to re-initialize the controller after resume. >> >> Signed-off-by: Claudiu Beznea >> --- >> drivers/i2c/busses/i2c-riic.c | 66 +++++++++++++++++++++++++++++------ >> 1 file changed, 55 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-riic.c b/drivers/i2c/busses/i2c-riic.c index >> 00fb09786e48..f9b9e92570d8 100644 >> --- a/drivers/i2c/busses/i2c-riic.c >> +++ b/drivers/i2c/busses/i2c-riic.c >> @@ -105,6 +105,8 @@ struct riic_dev { >> struct completion msg_done; >> struct i2c_adapter adapter; >> struct clk *clk; >> + struct reset_control *rstc; >> + struct i2c_timings i2c_t; >> }; >> >> struct riic_irq_desc { >> @@ -306,11 +308,12 @@ static const struct i2c_algorithm riic_algo = { >> .functionality = riic_func, >> }; >> >> -static int riic_init_hw(struct riic_dev *riic, struct i2c_timings *t) >> +static int riic_init_hw(struct riic_dev *riic) >> { >> int ret; >> unsigned long rate; >> int total_ticks, cks, brl, brh; >> + struct i2c_timings *t = &riic->i2c_t; >> struct device *dev = riic->adapter.dev.parent; >> >> if (t->bus_freq_hz > I2C_MAX_FAST_MODE_FREQ) { @@ -429,8 +432,6 @@ static int >> riic_i2c_probe(struct platform_device *pdev) >> struct device *dev = &pdev->dev; >> struct riic_dev *riic; >> struct i2c_adapter *adap; >> - struct i2c_timings i2c_t; >> - struct reset_control *rstc; >> int i, ret; >> >> riic = devm_kzalloc(dev, sizeof(*riic), GFP_KERNEL); @@ -447,16 +448,16 @@ static int >> riic_i2c_probe(struct platform_device *pdev) >> return PTR_ERR(riic->clk); >> } >> >> - rstc = devm_reset_control_get_optional_exclusive(dev, NULL); >> - if (IS_ERR(rstc)) >> - return dev_err_probe(dev, PTR_ERR(rstc), >> + riic->rstc = devm_reset_control_get_optional_exclusive(dev, NULL); >> + if (IS_ERR(riic->rstc)) >> + return dev_err_probe(dev, PTR_ERR(riic->rstc), >> "Error: missing reset ctrl\n"); >> >> - ret = reset_control_deassert(rstc); >> + ret = reset_control_deassert(riic->rstc); >> if (ret) >> return ret; >> >> - ret = devm_add_action_or_reset(dev, riic_reset_control_assert, rstc); >> + ret = devm_add_action_or_reset(dev, riic_reset_control_assert, >> +riic->rstc); >> if (ret) >> return ret; >> >> @@ -485,13 +486,13 @@ static int riic_i2c_probe(struct platform_device *pdev) >> >> init_completion(&riic->msg_done); >> >> - i2c_parse_fw_timings(dev, &i2c_t, true); >> + i2c_parse_fw_timings(dev, &riic->i2c_t, true); >> >> pm_runtime_set_autosuspend_delay(dev, 0); >> pm_runtime_use_autosuspend(dev); >> pm_runtime_enable(dev); >> >> - ret = riic_init_hw(riic, &i2c_t); >> + ret = riic_init_hw(riic); >> if (ret) >> goto out; >> >> @@ -501,7 +502,7 @@ static int riic_i2c_probe(struct platform_device *pdev) >> >> platform_set_drvdata(pdev, riic); >> >> - dev_info(dev, "registered with %dHz bus speed\n", i2c_t.bus_freq_hz); >> + dev_info(dev, "registered with %dHz bus speed\n", >> +riic->i2c_t.bus_freq_hz); >> return 0; >> >> out: >> @@ -561,6 +562,48 @@ static const struct riic_of_data riic_rz_v2h_info = { >> }, >> }; >> >> +static int riic_i2c_suspend(struct device *dev) { >> + struct riic_dev *riic = dev_get_drvdata(dev); >> + int ret; >> + >> + ret = pm_runtime_resume_and_get(dev); >> + if (ret) >> + return ret; >> + >> + i2c_mark_adapter_suspended(&riic->adapter); >> + >> + /* Disable output on SDA, SCL pins. */ >> + riic_clear_set_bit(riic, ICCR1_ICE, 0, RIIC_ICCR1); >> + >> + pm_runtime_mark_last_busy(dev); >> + pm_runtime_put_sync(dev); >> + >> + return reset_control_assert(riic->rstc); } >> + >> +static int riic_i2c_resume(struct device *dev) { >> + struct riic_dev *riic = dev_get_drvdata(dev); >> + int ret; >> + >> + ret = reset_control_deassert(riic->rstc); >> + if (ret) >> + return ret; >> + >> + ret = riic_init_hw(riic); >> + if (ret) >> + return ret; > > On error case we need to assert back?? Yes, it would be better as we cannot recover though other paths anymore, if that happens. > > Cheers, > Biju > >> + >> + i2c_mark_adapter_resumed(&riic->adapter); >> + >> + return 0; >> +} >> + >> +static const struct dev_pm_ops riic_i2c_pm_ops = { >> + SYSTEM_SLEEP_PM_OPS(riic_i2c_suspend, riic_i2c_resume) }; >> + >> static const struct of_device_id riic_i2c_dt_ids[] = { >> { .compatible = "renesas,riic-rz", .data = &riic_rz_a_info }, >> { .compatible = "renesas,riic-r9a09g057", .data = &riic_rz_v2h_info }, @@ -573,6 +616,7 @@ >> static struct platform_driver riic_i2c_driver = { >> .driver = { >> .name = "i2c-riic", >> .of_match_table = riic_i2c_dt_ids, >> + .pm = pm_ptr(&riic_i2c_pm_ops), >> }, >> }; >> >> -- >> 2.39.2 >> >