Re: [PATCH 3/3] ARM: dts: exynos: add function and color to aat1290 flash LED node in Galaxy S3

[Jacek Anaszewski <jacek.anaszewski@gmail.com>]

Hi Krzysztof,

On 6/7/22 10:53, Krzysztof Kozlowski wrote:
> Add common LED properties - the function and color - to aat1290 flash
> LED node in Galaxy S3.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> index 72901772fcad..d76f3678dcab 100644
> --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> @@ -7,6 +7,7 @@
>    */
>   
>   /dts-v1/;
> +#include <dt-bindings/leds/common.h>
>   #include "exynos4412-midas.dtsi"
>   
>   / {
> @@ -27,6 +28,8 @@ led-controller {
>   
>   		led {
>   			label = "flash";
> +			function = LED_FUNCTION_FLASH;
> +			color = <LED_COLOR_ID_WHITE>;

Addition of these two properties will not change anything because
the label has precedence. It is deprecated, but if you introduce
function and color to the binding instead of the label, the resulting
LED class device name will change.

>   			led-max-microamp = <520833>;
>   			flash-max-microamp = <1012500>;
>   			flash-max-timeout-us = <1940000>;

-- 
Best regards,
Jacek Anaszewski