* RE: [PATCH] dt-bindings: mmc: renesas,sdhi: Fix RZ/V2M clock description
2023-01-09 13:26 [PATCH] dt-bindings: mmc: renesas,sdhi: Fix RZ/V2M clock description Geert Uytterhoeven
@ 2023-01-09 15:16 ` Fabrizio Castro
2023-01-10 10:37 ` Krzysztof Kozlowski
2023-01-16 12:16 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Fabrizio Castro @ 2023-01-09 15:16 UTC (permalink / raw)
To: Geert Uytterhoeven, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Wolfram Sang
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Hi Geert,
Thanks for your patch!
> The SD Card/MMC interface on the Renesas RZ/V2M SoC uses 4 clocks, like
> on RZ/G2L SoCs.
>
> The current description specifies 3 clocks, like on R-Car Gen3, which
> will lead to "make dtbs_check" failures:
>
> arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dtb: mmc@85000000:
> clocks: [[3, 1, 18], [3, 1, 20], [3, 1, 19], [3, 1, 17]] is too long
> From schema:
> Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>
> Fixes: c8dbdf2a1044951b ("dt-bindings: mmc: renesas,sdhi: Document RZ/V2M
> support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Thanks,
Fab
> ---
> Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> index 4357736074898ff3..fa089cbb155bd0fb 100644
> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> @@ -122,6 +122,7 @@ allOf:
> - renesas,sdhi-r9a07g043
> - renesas,sdhi-r9a07g044
> - renesas,sdhi-r9a07g054
> + - renesas,sdhi-r9a09g011
> then:
> properties:
> clocks:
> --
> 2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: mmc: renesas,sdhi: Fix RZ/V2M clock description
2023-01-09 13:26 [PATCH] dt-bindings: mmc: renesas,sdhi: Fix RZ/V2M clock description Geert Uytterhoeven
2023-01-09 15:16 ` Fabrizio Castro
@ 2023-01-10 10:37 ` Krzysztof Kozlowski
2023-01-16 12:16 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-10 10:37 UTC (permalink / raw)
To: Geert Uytterhoeven, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Wolfram Sang, Fabrizio Castro
Cc: linux-mmc, devicetree, linux-renesas-soc
On 09/01/2023 14:26, Geert Uytterhoeven wrote:
> The SD Card/MMC interface on the Renesas RZ/V2M SoC uses 4 clocks, like
> on RZ/G2L SoCs.
>
> The current description specifies 3 clocks, like on R-Car Gen3, which
> will lead to "make dtbs_check" failures:
>
> arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dtb: mmc@85000000: clocks: [[3, 1, 18], [3, 1, 20], [3, 1, 19], [3, 1, 17]] is too long
> From schema: Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>
> Fixes: c8dbdf2a1044951b ("dt-bindings: mmc: renesas,sdhi: Document RZ/V2M support")
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: mmc: renesas,sdhi: Fix RZ/V2M clock description
2023-01-09 13:26 [PATCH] dt-bindings: mmc: renesas,sdhi: Fix RZ/V2M clock description Geert Uytterhoeven
2023-01-09 15:16 ` Fabrizio Castro
2023-01-10 10:37 ` Krzysztof Kozlowski
@ 2023-01-16 12:16 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2023-01-16 12:16 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rob Herring, Krzysztof Kozlowski, Wolfram Sang, Fabrizio Castro,
linux-mmc, devicetree, linux-renesas-soc
On Mon, 9 Jan 2023 at 14:26, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>
> The SD Card/MMC interface on the Renesas RZ/V2M SoC uses 4 clocks, like
> on RZ/G2L SoCs.
>
> The current description specifies 3 clocks, like on R-Car Gen3, which
> will lead to "make dtbs_check" failures:
>
> arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dtb: mmc@85000000: clocks: [[3, 1, 18], [3, 1, 20], [3, 1, 19], [3, 1, 17]] is too long
> From schema: Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>
> Fixes: c8dbdf2a1044951b ("dt-bindings: mmc: renesas,sdhi: Document RZ/V2M support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> index 4357736074898ff3..fa089cbb155bd0fb 100644
> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> @@ -122,6 +122,7 @@ allOf:
> - renesas,sdhi-r9a07g043
> - renesas,sdhi-r9a07g044
> - renesas,sdhi-r9a07g054
> + - renesas,sdhi-r9a09g011
> then:
> properties:
> clocks:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread