Re: [PATCH] riscv: dts: starfive: jh7110-common: Use named definition for mmc1 card detect

Conor Dooley
2024-12-17T18:33:19Z

[-- Attachment #1: Type: text/plain, Size: 1916 bytes --]

On Mon, Dec 16, 2024 at 07:25:59PM -0800, E Shattow wrote:
> Hi, Hal
>
> On 12/16/24 18:02, Hal Feng wrote:
> > > On 17.12.24 04:13, Conor Dooley wrote:
> > > On Mon, 09 Dec 2024 20:06:46 -0800, E Shattow wrote:
> > > > Use named definition for mmc1 card detect GPIO instead of numeric literal.
> > > >
> > > >
> > >
> > > Applied to riscv-dt-for-next, thanks!
> > >
> > > [1/1] riscv: dts: starfive: jh7110-common: Use named definition for mmc1
> > > card detect
> > > https://git.kernel.org/conor/c/c96f15d79172
> >
> > No, here "41" means the GPIO number, but GPI_SYS_SDIO1_CD means the
> > multiplexed function and should be used by pinctrl pinmux not gpio subsystem.
> > Although GPI-SYS_SDIO1_CD is numerically the same as 41.
> >
> > Best regards,
> > Hal
>
> You're right, Hal. I'm confused trying to make sense of this.
>
> From dts/upstream/src/riscv/starfive/jh7110-pinfunc.h:
>
> "gpio nr: gpio number, 0 - 63"
>
> And yet in dts/upstream/src/riscv/starfive/jh7110-common.dtsi there's:
>
> > pinmux = <PINMUX(64, 0)>,
> > <PINMUX(65, 0)>,
> > <PINMUX(66, 0)>,
> > <PINMUX(67, 0)>,
> > <PINMUX(68, 0)>,
> > <PINMUX(69, 0)>,
> > <PINMUX(70, 0)>,
> > <PINMUX(71, 0)>,
> > <PINMUX(72, 0)>,
> > <PINMUX(73, 0)>;
>
>
> Loosely on the subject of MMC interface and GPIO numbering, what is the
> above code doing? These are not GPIO numbers 0-63 so what is this?
>
> I'm trying to understand this so I can write the Mars CM (-Lite) dts.
>

> Conor, and Hal: sorry for the mistake there.

No worries, I've dropped the patch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]