From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jae Hyun Yoo Subject: Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs Date: Wed, 21 Feb 2018 12:35:35 -0800 Message-ID: <4afd2fec-b015-72d4-300e-3dd7696f6ff0@linux.intel.com> References: <20180221161606.32247-1-jae.hyun.yoo@linux.intel.com> <20180221161606.32247-3-jae.hyun.yoo@linux.intel.com> <20180221171349.GG29204@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180221171349.GG29204@lunn.ch> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andrew Lunn Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, jdelvare@suse.com, arnd@arndb.de, linux-doc@vger.kernel.org, andrew@aj.id.au, gregkh@linuxfoundation.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, joel@jms.id.au, benh@kernel.crashing.org, linux@roeck-us.net, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 2/21/2018 9:13 AM, Andrew Lunn wrote: > On Wed, Feb 21, 2018 at 08:16:00AM -0800, Jae Hyun Yoo wrote: >> This commit adds a dt-bindings document of PECI adapter driver for Aspeed >> AST24xx/25xx SoCs. > > Hi Jae > > It would be good to separate this into two. One binding document for a > generic adaptor, with a generic PECI bus, and generic client > devices. List all the properties you expect at the generic level. > > Then have an aspeed specific binding for those properties which are > specific to the Aspeed adaptor. > That makes sense. I'll add generic PECI bus/adapter/client and Aspeed specific documents as separated. > Andrew > > Thanks again for sharing your time to review it. I really appreciate it. BR, Jae