From: Krzysztof Kozlowski <krzk@kernel.org>
To: Conor Dooley <conor@kernel.org>, Jianping.Shen@de.bosch.com
Cc: jic23@kernel.org, lars@metafoo.de, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, dima.fedrau@gmail.com,
marcelo.schmitt1@gmail.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Christian.Lorenz3@de.bosch.com, Ulrike.Frauendorf@de.bosch.com,
Kai.Dolde@de.bosch.com
Subject: Re: [PATCH v7 1/2] dt-bindings: iio: imu: smi240: add Bosch smi240
Date: Tue, 17 Sep 2024 18:58:24 +0200 [thread overview]
Message-ID: <4b2e30c8-8fdb-4084-9fdd-adff904fb325@kernel.org> (raw)
In-Reply-To: <20240913-curled-cement-0434c7b56e17@spud>
On 13/09/2024 19:54, Conor Dooley wrote:
> On Fri, Sep 13, 2024 at 12:00:10PM +0200, Jianping.Shen@de.bosch.com wrote:
>> From: Shen Jianping <Jianping.Shen@de.bosch.com>
>>
>> add devicetree binding for Bosch imu smi240.
>> The smi240 is a combined three axis angular rate and
>> three axis acceleration sensor module.
>>
>> * The smi240 requires VDD and VDDIO
>> * Provides only spi interface.
>>
>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> 3 reviews? Doing well for yourself!
There is certainly mess here, but that's correct. We both reviewed older
version and then new version was posted ignoring our tags. So Rob gave
review.
Changelog is so vague that I have no clue...
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-17 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 10:00 [PATCH v7 0/2] iio: imu: smi240: add bosch smi240 driver Jianping.Shen
2024-09-13 10:00 ` [PATCH v7 1/2] dt-bindings: iio: imu: smi240: add Bosch smi240 Jianping.Shen
2024-09-13 17:54 ` Conor Dooley
2024-09-17 16:58 ` Krzysztof Kozlowski [this message]
2024-09-17 20:42 ` Conor Dooley
2024-09-13 10:00 ` [PATCH v7 2/2] iio: imu: smi240: add driver Jianping.Shen
2024-09-14 16:32 ` Jonathan Cameron
2024-09-16 20:32 ` Shen Jianping (ME-SE/EAD2)
2024-09-17 11:13 ` Jonathan Cameron
2024-09-17 13:13 ` Shen Jianping (ME-SE/EAD2)
2024-09-28 14:36 ` Jonathan Cameron
2024-09-17 16:59 ` [PATCH v7 0/2] iio: imu: smi240: add bosch smi240 driver Krzysztof Kozlowski
2024-09-18 8:14 ` Shen Jianping (ME-SE/EAD2)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b2e30c8-8fdb-4084-9fdd-adff904fb325@kernel.org \
--to=krzk@kernel.org \
--cc=Christian.Lorenz3@de.bosch.com \
--cc=Jianping.Shen@de.bosch.com \
--cc=Kai.Dolde@de.bosch.com \
--cc=Ulrike.Frauendorf@de.bosch.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dima.fedrau@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).