devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	linux-power <linux-power@fi.rohmeurope.com>
Subject: Re: [PATCH 1/2] dt-bindings: mfd: rohm,bd71847-pmic: Document rohm,clock-output-is-critical property
Date: Wed, 20 Oct 2021 13:06:13 +0200	[thread overview]
Message-ID: <4b3cc52c-a618-ea7d-6778-68060cfadf8e@denx.de> (raw)
In-Reply-To: <263da45f-d648-3c65-aed3-e4ba41927911@fi.rohmeurope.com>

On 10/20/21 12:14 PM, Vaittinen, Matti wrote:
[...]

> I wonder if this really is something specific to ROHM ICs? Do you think
> this would warrant a generic, non vendor specific property? I am Ok with
> the ROHM specific property too but it just seems to me this might not be
> unique to ROHM IC(s).
> 
> By the way, the very same clk driver where you implemented the property
> reading (patch 2/2) is used by few other ROHM PMICs. At least by
> BD71837, BD71828, BD71815, BD9576 and BD9573. So the code change here
> adds support for this property to all of those PMICs. I wonder if the
> property should be mentioned in all of the binding docs... That could be
> another argument for making this a generic property and describing it in
> clk yaml ;)
> 
> Well, just my 10 Cents - I am ok with this change as you presented it
> here if you don't think this should be generic one.

I think we need something like gpio-hog, except for clock. Some clk-hog 
maybe ? That would be useful not only here, but also for things where 
some output generates clock for random stuff which cannot be described 
in the DT for whatever reason (like e.g. the SoC is used as a substitute 
for CPLD XTAL and the CPLD isn't connected to the SoC in any other way).

  reply	other threads:[~2021-10-20 11:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20  8:49 [PATCH 1/2] dt-bindings: mfd: rohm,bd71847-pmic: Document rohm,clock-output-is-critical property Marek Vasut
2021-10-20  8:49 ` [PATCH 2/2] clk: bd718x7: Add " Marek Vasut
2021-10-20 10:14 ` [PATCH 1/2] dt-bindings: mfd: rohm,bd71847-pmic: Document " Vaittinen, Matti
2021-10-20 11:06   ` Marek Vasut [this message]
2021-10-28 21:24     ` Rob Herring
2021-10-29  7:43       ` Vaittinen, Matti
2021-11-08 15:01       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b3cc52c-a618-ea7d-6778-68060cfadf8e@denx.de \
    --to=marex@denx.de \
    --cc=Matti.Vaittinen@fi.rohmeurope.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-power@fi.rohmeurope.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).