From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CABC4332F for ; Tue, 15 Nov 2022 13:00:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229873AbiKONA5 (ORCPT ); Tue, 15 Nov 2022 08:00:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbiKONA4 (ORCPT ); Tue, 15 Nov 2022 08:00:56 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 472CE64CB for ; Tue, 15 Nov 2022 05:00:55 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id a29so24285661lfj.9 for ; Tue, 15 Nov 2022 05:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=70m8oznMfX8D7FgeqW5r54t/DO3+ve+HYcPm4xJoTA0=; b=U6JGpD/DvPN3NuziaHicc79ZuFNcr/eqNelojIx/IDa1GGtKmFqVrBjq77N+GL3wHp O1o+ak6c9oWHABOYhw0nsDcn+TdeVRDMrtApsZYZUwcqCO9hLTqR6/ItndULHTtePSSp vKkSVWbr2/gts/blr9SK29JwiSuESPJYHHkLHEXLmHe6goZRVoKiZhpig4dlHku96z4g el3catMWVVvYWWOP6zdx6q07xQ4+NTXMF+JatUKRkTvv7CV44qwCLpOrPBH79E10w0cQ xZgFONptqcAQErek4N1hQRyeGAhz0MhPnITX4gqZYwzb0Dh/6IfmjhVkFHLvX9j+jsHk 3GgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=70m8oznMfX8D7FgeqW5r54t/DO3+ve+HYcPm4xJoTA0=; b=x0D5SrX/khHzwyJV0OsDtELzL7oMv+OQTYvmC0DrfzHq5g3lXbnqzaAzf3vRTjtpaj +njmt8YBXgttgFIXaQOaLZHj8JfQ8lrpHkgnPBew4JtjYtwRuztPftTkdClQPR488JcH S9YPNcrnsgNQbNfDD6PLOcN6mBr1hnVehvFH7ODue1rn7IQbtMuD6/swDzW9eKq7fXOU yXIyy4gliBXKLfSBOtzRnvfxVTibhftJIBZMT7WZffwidNBBjuXAZk19OHpQDfYJ0f/X Hw2FZCR/iIQvlYDds9Qc8fC/oHOtYCdUNHBeHJGihwPpIs3C1t59Om97/jHY2eXY4bi6 x1Ig== X-Gm-Message-State: ANoB5pl5P5RrnfkdEJ9nuklHj9yak98RjsGojh45KRXCrF2Qk6FtB2uS djOMdjj0rpwVTEBJQbR0tPlEBQ== X-Google-Smtp-Source: AA0mqf4VW9V70EMxLEXPhw/UNHewRxLppRZt48MhrNghBRu8nQxl7mgNcRNC2imT4tWPTJ+YLhrgCA== X-Received: by 2002:a19:6748:0:b0:4aa:22b8:fa9d with SMTP id e8-20020a196748000000b004aa22b8fa9dmr5507795lfj.491.1668517253498; Tue, 15 Nov 2022 05:00:53 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a21-20020ac25e75000000b00494603953b6sm2204322lfr.6.2022.11.15.05.00.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 05:00:52 -0800 (PST) Message-ID: <4b4ca3ba-8e4d-088e-8b3e-a47ad6ecb965@linaro.org> Date: Tue, 15 Nov 2022 14:00:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 1/9] dt-bindings: arm-smmu: Allow up to 3 power-domains Content-Language: en-US To: Konrad Dybcio , linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: patches@linaro.org, Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221114104222.36329-1-konrad.dybcio@linaro.org> <20221114104222.36329-2-konrad.dybcio@linaro.org> <6fa8e3ea-2113-d930-96bc-3726d53e5bcd@linaro.org> <0121fc03-b027-7659-5e6e-b42089c9888d@linaro.org> <12578e05-ced9-e5f7-7922-0af2f2159333@linaro.org> <878402e7-7f80-31c7-3a6b-989a6ca29841@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/11/2022 13:54, Konrad Dybcio wrote: > > > On 14/11/2022 17:58, Krzysztof Kozlowski wrote: >> On 14/11/2022 16:53, Konrad Dybcio wrote: >>> >>> On 14/11/2022 14:00, Krzysztof Kozlowski wrote: >>>> On 14/11/2022 12:17, Konrad Dybcio wrote: >>>>> On 14/11/2022 12:01, Krzysztof Kozlowski wrote: >>>>>> On 14/11/2022 11:42, Konrad Dybcio wrote: >>>>>>> Some SMMUs require that a vote is held on as much as 3 separate PDs >>>>>>> (hello Qualcomm). Allow it in bindings. >>>>>>> >>>>>>> Signed-off-by: Konrad Dybcio >>>>>>> --- >>>>>>> Changes since v1: >>>>>>> - Add minItems >>>>>>> >>>>>>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 ++- >>>>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>>>> >>>>>>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>>>>>> index 9066e6df1ba1..82bc696de662 100644 >>>>>>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>>>>>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>>>>>> @@ -159,7 +159,8 @@ properties: >>>>>>> through the TCU's programming interface. >>>>>>> >>>>>>> power-domains: >>>>>>> - maxItems: 1 >>>>>>> + minItems: 0 >>>>>> It cannot be 0. >>>>>> >>>>>> minItems: 1 >>>>>> >>>>>> Anyway you still need to restrict it per variant, as I said in previous >>>>>> version. >>>>> Hm.. I'm not entirely sure what you mean.. Should I add a list of >>>>> compatibles >>>> Yes and limit it to maxItems: 1 for "else". >>> >>> I tried adding: >>> >>> >>> >>>   - if: >>>       properties: >>>         compatible: >>>           contains: >>>             enum: >>>               - qcom,sm6375-smmu-500 >>>     then: >>>       properties: >>>         power-domains: >>>           minItems: 3 >>>           maxItems: 3 >>>     else: >>>       properties: >>>         power-domains: >>>           maxItems: 1 >>> >>> >>> Right under the nvidia reg if-else in the allOf, but dtbs_check throws >>> errors like: >>> >>> >>> /home/konrad/linux/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dtb: >>> iommu@5040000: 'power-domains' does not match any of the regexes: >>> 'pinctrl-[0-9]+' >>> >>> >>> Any clues as to why? >> >> I don't know what code do you have there, but generic pattern is: >> >> https://elixir.bootlin.com/linux/v5.19-rc6/source/Documentation/devicetree/bindings/clock/samsung,exynos7-clock.yaml#L38 >> > I tried many things, but I still don't seem to get a hang of it.. Here's > my current diff rebased on top of Dmitry's recent cleanups (available at > [1]) > > > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > index 28f5720824cd..55759aebc4a0 100644 > --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > @@ -200,7 +200,7 @@ properties: > maxItems: 7 > > power-domains: As I mentioned before - minItems: 1. Just like the link I gave you. > - maxItems: 1 > + maxItems: 3 > > nvidia,memory-controller: > description: | > @@ -364,6 +364,26 @@ allOf: > - description: interface clock required to access smmu's > registers > through the TCU's programming interface. > > + - if: > + properties: > + compatible: > + contains: > + const: qcom,sm6375-smmu-500 > + then: > + properties: > + power-domains: > + items: > + - description: SNoC MMU TBU RT GDSC > + - description: SNoC MMU TBU NRT GDSC > + - description: SNoC TURING MMU TBU0 GDSC > + > + required: > + - power-domains > + else: > + properties: > + power-domains: > + maxItems: 1 > + > examples: > - |+ > /* SMMU with stream matching or stream indexing */ > > > In my eyes, this should work, but I still get errors like: > > /home/konrad/linux/arch/arm64/boot/dts/qcom/sm8250-hdk.dtb: > iommu@3da0000: power-domains: [[108, 0]] is too short > > as if the else: path was never taken.. It was, but the top-level property said that minItems=3 (implicitly), so it is too short. Best regards, Krzysztof