From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0076C43334 for ; Thu, 21 Jul 2022 07:22:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231686AbiGUHWo (ORCPT ); Thu, 21 Jul 2022 03:22:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbiGUHWn (ORCPT ); Thu, 21 Jul 2022 03:22:43 -0400 X-Greylist: delayed 552 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 21 Jul 2022 00:22:41 PDT Received: from 4.mo581.mail-out.ovh.net (4.mo581.mail-out.ovh.net [178.32.122.254]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFCCD3F33E for ; Thu, 21 Jul 2022 00:22:41 -0700 (PDT) Received: from player758.ha.ovh.net (unknown [10.109.146.53]) by mo581.mail-out.ovh.net (Postfix) with ESMTP id 1CB0322D54 for ; Thu, 21 Jul 2022 07:13:27 +0000 (UTC) Received: from RCM-web2.webmail.mail.ovh.net (ip-194-187-74-233.konfederacka.maverick.com.pl [194.187.74.233]) (Authenticated sender: rafal@milecki.pl) by player758.ha.ovh.net (Postfix) with ESMTPSA id D07AF2CD18D4F; Thu, 21 Jul 2022 07:13:14 +0000 (UTC) MIME-Version: 1.0 Date: Thu, 21 Jul 2022 09:13:14 +0200 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Krzysztof Kozlowski Cc: William Zhang , Linux ARM List , joel.peshkin@broadcom.com, dan.beygelman@broadcom.com, Rob Herring , Krzysztof Kozlowski , Anand Gore , Kursad Oney , Florian Fainelli , Broadcom internal kernel review list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description In-Reply-To: <193845cb-6149-1ae6-5eb6-6b01ffcf763b@linaro.org> References: <20220721000658.29537-1-william.zhang@broadcom.com> <883c2ad4c36220b488519a8902ad72bc@milecki.pl> <193845cb-6149-1ae6-5eb6-6b01ffcf763b@linaro.org> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <4b5100e4a6e9e581f4b8ab58e5ca4927@milecki.pl> X-Sender: rafal@milecki.pl X-Originating-IP: 194.187.74.233 X-Webmail-UserID: rafal@milecki.pl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 18201016422655699931 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudelkedgvdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepggffhffvvefujghffgfkgihitgfgsehtkehjtddtreejnecuhfhrohhmpeftrghfrghlpgfoihhlvggtkhhiuceorhgrfhgrlhesmhhilhgvtghkihdrphhlqeenucggtffrrghtthgvrhhnpeevjefhffffveeludejfedtvdfftdekgffghfegieeliedvfeeigfejteejjeekfeenucfkpheptddrtddrtddrtddpudelgedrudekjedrjeegrddvfeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejheekrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheprhgrfhgrlhesmhhilhgvtghkihdrphhlpdhnsggprhgtphhtthhopedupdhrtghpthhtohepuggvvhhitggvthhrvggvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehkedu Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-07-21 09:01, Krzysztof Kozlowski wrote: > On 21/07/2022 08:51, Rafał Miłecki wrote: >> On 2022-07-21 08:44, Krzysztof Kozlowski wrote: >>> On 21/07/2022 02:06, William Zhang wrote: >>>> Append "brcm,bcmbca" to BCM4908 chip family compatible strings. Add >>>> generic 4908 board entry. >>> >>> This does not explain at all why you are doing it. Improve your >>> commit >>> messages. >> >> To clarify it from my side (and maybe help a bit): >> >> 1. As I understand it BCMBCA is a one big family of SoCs. >> 2. BCM4908 is a subset of that family (a subfamily?) designed for a >> specific group of devices. >> >> If that's correct I think William it's what you should describe in >> your >> commit message. That would make binding more accurate and should be a >> good argument for your change (I believe). > > That's better argument. But what's the benefit of adding generic > compatible? Devices cannot bind to it (it is too generic). Does it > describe the device anyhow? Imagine someone adding compatible > "brcm,all-soc-of-broadcom" - does it make any sense? OK, I see it now. I can't think of any case of handling all devices covered with suc a wide brcm,bcmbca binding. This leads me to another question if we should actually totally drop brcm,bcmbca from other SoCs bindings, see linux-next's Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml