From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: rtc: max31335: add max31335 bindings
Date: Wed, 1 Nov 2023 16:11:23 +0100 [thread overview]
Message-ID: <4b7b1f74-5467-4a2f-a5f3-c47eb4fa5006@linaro.org> (raw)
In-Reply-To: <20231101094835.51031-1-antoniu.miclaus@analog.com>
On 01/11/2023 10:48, Antoniu Miclaus wrote:
> Document the Analog Devices MAX31335 device tree bindings.
>
...
>;
> + #size-cells = <0>;
> +
> + rtc@68 {
> + compatible = "adi,max31335";
> + reg = <0x68>;
> + pinctrl-0 = <&rtc_nint_pins>;
> + interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
> + trickle-resistor-ohms = <6000>;
> + aux-voltage-chargeable =<1>;
Missing space after '='.
Keep Reviewed-by tag.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-11-01 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 9:48 [PATCH v4 1/2] dt-bindings: rtc: max31335: add max31335 bindings Antoniu Miclaus
2023-11-01 9:48 ` [PATCH v4 2/2] rtc: max31335: add driver support Antoniu Miclaus
2023-11-01 14:21 ` Guenter Roeck
2023-11-01 15:21 ` Miclaus, Antoniu
2023-11-01 15:30 ` Guenter Roeck
2023-11-01 22:23 ` Alexandre Belloni
2023-11-02 13:44 ` Miclaus, Antoniu
2023-11-02 16:57 ` Alexandre Belloni
2023-11-02 17:17 ` Guenter Roeck
2023-11-01 15:11 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b7b1f74-5467-4a2f-a5f3-c47eb4fa5006@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).