From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>,
krzysztof.kozlowski@linaro.or
Cc: patrick@stwcx.xyz, garnermic@fb.com,
Bonnie Lo <Bonnie_Lo@Wiwynn.com>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH v3] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
Date: Fri, 7 Oct 2022 09:06:37 +0200 [thread overview]
Message-ID: <4b861177-df32-ab9c-c746-f32f0ee6438d@linaro.org> (raw)
In-Reply-To: <20221007055346.3484180-1-Delphine_CC_Chiu@Wiwynn.com>
On 07/10/2022 07:53, Delphine CC Chiu wrote:
> Add linux device tree entry related to
> greatlakes specific devices connected to BMC SoC.
>
> ---
> --- v3 - Add documentation of board compatible (bindings)
> --- - Add board compatible
> --- - Remove the bootargs
> --- - Revise the DTS node name
> ---
> --- v2 - Add binding document
> ---
> --- v1 - Initial draft
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
> ---
>
> Signed-off-by: Bonnie Lo <Bonnie_Lo@Wiwynn.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> .../dts/aspeed-bmc-facebook-greatlakes.dts | 241 ++++++++++++++++++
You need to document the binding. I think you already did, but then
submitted without it. Read the process:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-07 7:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 5:53 [PATCH v3] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC Delphine CC Chiu
2022-10-07 7:06 ` Krzysztof Kozlowski [this message]
2022-11-11 3:48 ` [PATCH v4 0/2] ARM: dts: Facebook Greatlakes platform Delphine CC Chiu
2022-11-11 3:48 ` [PATCH v4 1/2] dt-bindings: arm: aspeed: add Facebook Greatlakes board Delphine CC Chiu
2022-11-11 8:21 ` Krzysztof Kozlowski
2022-11-11 3:48 ` [PATCH v4 2/2] ARM: dts: aspeed: greatlakes: Add Facebook greatlakes (AST2600) BMC Delphine CC Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b861177-df32-ab9c-c746-f32f0ee6438d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Bonnie_Lo@Wiwynn.com \
--cc=Delphine_CC_Chiu@Wiwynn.com \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=garnermic@fb.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.or \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=patrick@stwcx.xyz \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).